RPM packaging: systemd service files

[Ananda Samaddar]

Hello all,

I'm attempting to package Kwakd for Fedora.  I'm pretty new to rpm
packaging but have already managed to build and package some simple
stuff.

I can get kwakd to build and package properly apart from one thing.
The systemd service file needs to be copied to the appropriate
directory and it doesn't seem to be working.  Here are the relevant
parts of the spec file:

	%install
	make install DESTDIR=$RPM_BUILD_ROOT
	cp %{name}.service %{_unitdir}

	%files 
	%doc README NEWS ChangeLog COPYING AUTHORS TODO
	%{_bindir}/%{name}
	%{_mandir}/man1/%{name}.1.gz
	%{_unitdir}/%{name}.service

The error I get is this:

+ cp kwakd.service /usr/lib/systemd/system
cp: cannot create regular file '/usr/lib/systemd/system/kwakd.service':
  Permission denied error: Bad exit status from /var/tmp/rpm-tmp.vQB9sv
  (%install)

What am I doing wrong?  If this is the wrong mailing list then please
point me to the correct one if you can too!

thanks,

Ananda Samaddar

[Reindl Harald]

Am 28.07.2013 19:57, schrieb আনন্দ কুমার সমাদ্দার Ananda Samaddar:
>  I can get kwakd to build and package properly apart from one thing.
>  The systemd service file needs to be copied to the appropriate
>  directory and it doesn't seem to be working.  Here are the relevant
>  parts of the spec file:
>  
>  	%install
>  	make install DESTDIR=$RPM_BUILD_ROOT
>  	cp %{name}.service %{_unitdir} 
*anything* inside install has to use the %{buildroot}% macro
cp %{name}.service %{buildroot}%{_unitdir}/

[Ananda Samaddar]

On Sun, 28 Jul 2013 20:01:42 +0200
Reindl Harald <h.reindl(a)thelounge.net&gt; wrote:

>  
>  
>  Am 28.07.2013 19:57, schrieb আনন্দ কুমার সমাদ্দার Ananda Samaddar:
>  > I can get kwakd to build and package properly apart from one thing.
>  > The systemd service file needs to be copied to the appropriate
>  > directory and it doesn't seem to be working.  Here are the relevant
>  > parts of the spec file:
>  > 
>  > 	%install
>  > 	make install DESTDIR=$RPM_BUILD_ROOT
>  > 	cp %{name}.service %{_unitdir}
>  
>  *anything* inside install has to use the %{buildroot}% macro
>  cp %{name}.service %{buildroot}%{_unitdir}/
>   
It's still not working.  I have: 

	BuildRequires: systemd

In the spec file.

With your suggestion I get the following error:

+ cp
kwakd.service
/home/ananda/rpmbuild/BUILDROOT/kwakd-0.3-1.fc19.x86_64/usr/lib/systemd/system/
cp: cannot create regular file
'/home/ananda/rpmbuild/BUILDROOT/kwakd-0.3-1.fc19.x86_64/usr/lib/systemd/system/':
No such file or directory 
error: Bad exit status from /var/tmp/rpm-tmp.7hHDNH (%install)


Ananda

[Reindl Harald]

Am 28.07.2013 20:08, schrieb আনন্দ কুমার সমাদ্দার Ananda Samaddar:
>  On Sun, 28 Jul 2013 20:01:42 +0200
>  Reindl Harald <h.reindl(a)thelounge.net&gt; wrote:
>  
> > Am 28.07.2013 19:57, schrieb আনন্দ কুমার সমাদ্দার Ananda Samaddar:
> >> I can get kwakd to build and package properly apart from one thing.
> >> The systemd service file needs to be copied to the appropriate
> >> directory and it doesn't seem to be working.  Here are the relevant
> >> parts of the spec file:
> >>
> >> 	%install
> >> 	make install DESTDIR=$RPM_BUILD_ROOT
> >> 	cp %{name}.service %{_unitdir}
> >
> > *anything* inside install has to use the %{buildroot}% macro
> > cp %{name}.service %{buildroot}%{_unitdir}/
> >
>  
>  It's still not working.  I have: 
>  
>  	BuildRequires: systemd
>  
>  In the spec file.
>  
>  With your suggestion I get the following error:
>  
>  + cp
>  kwakd.service
> /home/ananda/rpmbuild/BUILDROOT/kwakd-0.3-1.fc19.x86_64/usr/lib/systemd/system/
>  cp: cannot create regular file
>
> '/home/ananda/rpmbuild/BUILDROOT/kwakd-0.3-1.fc19.x86_64/usr/lib/systemd/system/':
>  No such file or directory 
>  error: Bad exit status from /var/tmp/rpm-tmp.7hHDNH (%install) 
mkdir %{buildroot}%{_unitdir}/
cp %{name}.service %{buildroot}%{_unitdir}/

"%{name}.service" is usually in rpmbuild/SOURCES/
look at existing src.rpms, thats how i learned to build packages

[Ananda Samaddar]

On Sun, 28 Jul 2013 19:08:20 +0100
আনন্দ কুমার সমাদ্দার Ananda Samaddar <asamaddar(a)myopera.com&gt; wrote:

>  On Sun, 28 Jul 2013 20:01:42 +0200
>  Reindl Harald <h.reindl(a)thelounge.net&gt; wrote:
>  
>  > 
>  > 
>  > Am 28.07.2013 19:57, schrieb আনন্দ কুমার সমাদ্দার Ananda Samaddar:
>  > > I can get kwakd to build and package properly apart from one
>  > > thing. The systemd service file needs to be copied to the
>  > > appropriate directory and it doesn't seem to be working.  Here
>  > > are the relevant parts of the spec file:
>  > > 
>  > > 	%install
>  > > 	make install DESTDIR=$RPM_BUILD_ROOT
>  > > 	cp %{name}.service %{_unitdir}
>  > 
>  > *anything* inside install has to use the %{buildroot}% macro
>  > cp %{name}.service %{buildroot}%{_unitdir}/
>  > 
>  
>  It's still not working.  I have: 
>  
>  	BuildRequires: systemd
>  
>  In the spec file.
>  
>  With your suggestion I get the following error:
>  
>  + cp
>  kwakd.service
> /home/ananda/rpmbuild/BUILDROOT/kwakd-0.3-1.fc19.x86_64/usr/lib/systemd/system/
>  cp: cannot create regular file
>
> '/home/ananda/rpmbuild/BUILDROOT/kwakd-0.3-1.fc19.x86_64/usr/lib/systemd/system/':
>  No such file or directory 
>  error: Bad exit status from /var/tmp/rpm-tmp.7hHDNH (%install)
>  
>  
>  Ananda
>    
OK I fixed it by adding this:

mkdir -p %{buildroot}%{_unitdir}/

before copying the service file.

It's always the most obvious and daft things!

Ananda

[Rahul Sundaram]

Hi


>  OK I fixed it by adding this:
>
>  mkdir -p %{buildroot}%{_unitdir}/
>
>  before copying the service file.
>
>  It's always the most obvious and daft things!
>  
Glad you found the solution.  You might want to use install instead of cp
however and if you are interested in packaging this officially for Fedora,
please post the full spec for review.  Thanks

Rahul

[Ananda Samaddar]

On Sun, 28 Jul 2013 18:13:24 -0400
Rahul Sundaram <metherid(a)gmail.com&gt; wrote:

>  Hi
>  
>  
>  > OK I fixed it by adding this:
>  >
>  > mkdir -p %{buildroot}%{_unitdir}/
>  >
>  > before copying the service file.
>  >
>  > It's always the most obvious and daft things!
>  >
>  
>  Glad you found the solution.  You might want to use install instead
>  of cp however and if you are interested in packaging this officially
>  for Fedora, please post the full spec for review.  Thanks
>  
>  Rahul 
I've done as you suggested.  The full spec is attached to this email.
I'm going to use it in conjunction with this:

http://gaenserich.github.io/hostsblock/

I'll have a look at packaging that shortly.

Ananda

[Rahul Sundaram]

Hi


On Sun, Jul 28, 2013 at 6:45 PM, আনন্দ কুমার সমাদ্দার  wrote:

>  On Sun, 28 Jul 2013 18:13:24 -0400I've done as you suggested. 
> The full
>  spec is attached to this email.
>  I'm going to use it in conjunction with this:
>
>  http://gaenserich.github.io/hostsblock/
>
>  I'll have a look at packaging that shortly.
>  
License should be GPLv2+ as per the header in the upstream source (kwadk.c)

You can use %make_install macro

Upstream shouldn't be hard coding the path of the binary and you should
report the issue to them

If you want to submit it for Fedora, follow

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

Rahul



Rahul

[Ananda Samaddar]

On Sun, 28 Jul 2013 19:00:13 -0400
Rahul Sundaram <metherid(a)gmail.com&gt; wrote:

>  Hi
>  
>  
>  On Sun, Jul 28, 2013 at 6:45 PM, আনন্দ কুমার সমাদ্দার  wrote:
>  
>  > On Sun, 28 Jul 2013 18:13:24 -0400I've done as you suggested.  The
>  > full spec is attached to this email.
>  > I'm going to use it in conjunction with this:
>  >
>  > http://gaenserich.github.io/hostsblock/
>  >
>  > I'll have a look at packaging that shortly.
>  >
>  
>  License should be GPLv2+ as per the header in the upstream source
>  (kwadk.c)
>  
>  You can use %make_install macro
>  
>  Upstream shouldn't be hard coding the path of the binary and you
>  should report the issue to them
>  
>  If you want to submit it for Fedora, follow
>  
>  https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
>  
>  Rahul
>  
>  
>  
>  Rahul 
OK I'll get on to upstream to fix his systemd service and COPYING files.

Ananda