rpmbuild --define - some rpm sorcerer around?

[lejeczek]

hi

how do you pass vars to rpmbuild for definition? eg

rpmbuild --define \'"${_definition2}"\'

I've been fiddling with ways to escape, but none is fricking working..
I mean, rpmbuild rushes to work(no errors nor failure) so if you try 
just command line do not believe it, because later as it executes %if 
you will see process does not see these definitions.

many thanks, L.

[Todd Zullinger]

Hi,

lejeczek via users wrote:
>  how do you pass vars to rpmbuild for definition? eg
>  
>  rpmbuild --define \'"${_definition2}"\'
>  
>  I've been fiddling with ways to escape, but none is fricking working..
>  I mean, rpmbuild rushes to work(no errors nor failure) so if you try just
>  command line do not believe it, because later as it executes %if you will
>  see process does not see these definitions. 
The format would be --define '_definition2 value'.  The you
would use %{_definition2} in your spec file, (which I'm
presuming you already have, it's just not being defined).

The man page explains is this way:

    -D, --define='MACRO EXPR'
            Defines MACRO with value EXPR.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It's not denial. I'm just very selective about what I accept as
reality.
    -- Calvin ("Calvin and Hobbes")

[lejeczek]

On 08/06/18 16:39, Todd Zullinger wrote:
>  Hi,
>
>  lejeczek via users wrote:
> > how do you pass vars to rpmbuild for definition? eg
> >
> > rpmbuild --define \'"${_definition2}"\'
> >
> > I've been fiddling with ways to escape, but none is fricking working..
> > I mean, rpmbuild rushes to work(no errors nor failure) so if you try just
> > command line do not believe it, because later as it executes %if you will
> > see process does not see these definitions.
>  The format would be --define '_definition2 value'.  The you
>  would use %{_definition2} in your spec file, (which I'm
>  presuming you already have, it's just not being defined).
>
>  The man page explains is this way:
>
>       -D, --define='MACRO EXPR'
>               Defines MACRO with value EXPR.
>
>  
Try to pass bash var to rpmbuild, eg:

$ _def1="_me 1"
$ rpmbuild --define=${_def1}

%if does not seem to catch/see these definitions. Like I 
said rpmbuild will run but you should see it is not there as 
.spec gets digested & processed.

>  _______________________________________________
>  users mailing list -- users(a)lists.fedoraproject.org
>  To unsubscribe send an email to users-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedoraproject.org/archives/list/[e-mail].o...

[Ulf Volmer]

On 08.06.2018 23:58, lejeczek via users wrote:

>  $ _def1="_me 1"
>  $ rpmbuild --define=${_def1} 
Try double quotes around your macro:

$ rpmbuild --define "${_def1}"

best regards
Ulf

[Rick Stevens]

On 06/08/2018 03:24 PM, Ulf Volmer wrote:
>  On 08.06.2018 23:58, lejeczek via users wrote:
>  
> > $ _def1="_me 1"
> > $ rpmbuild --define=${_def1}
>  
>  Try double quotes around your macro:
>  
>  $ rpmbuild --define "${_def1}" 
The man page specifies:

	--define='MACRO EXPR'

Meaning that the macro "%{MACRO}" in your script would be replaced with
the text "EXPR" (in this example case). Something like:

	--define='_my_macro `uname -r`'

means that "%{_my_macro}" in the script would be replaced with the
result of the "uname -r" command (the backticks around the uname command
are so the command is executed...just like in the shell).

In other words, the argument to the "--define=" flag consists of two
items: the macro name itself and its definition. The macro name and its
definition must be separated by a space. Because they must be separated
by a space, the whole bit after the "=" must be quoted somehow so the
shell doesn't consume them as two separate items.
----------------------------------------------------------------------
- Rick Stevens, Systems Engineer, AllDigital    ricks(a)alldigital.com -
- AIM/Skype: therps2        ICQ: 226437340           Yahoo: origrps2 -
-                                                                    -
-                He who laughs last thinks slowest.                  -
----------------------------------------------------------------------

[Ulf Volmer]

On 09.06.2018 00:50, Rick Stevens wrote:
>  On 06/08/2018 03:24 PM, Ulf Volmer wrote:
> > On 08.06.2018 23:58, lejeczek via users wrote:
> >
> >> $ _def1="_me 1"
> >> $ rpmbuild --define=${_def1}
> >
> > Try double quotes around your macro:
> >
> > $ rpmbuild --define "${_def1}"
>  
>  The man page specifies: 
Yes, that's why i recommend the line above. please keep in mind that
double quotes are needed for the OP to resolve the variable. And the
equal sign is not a hard reqiurement in this case.

best regards
Ulf

[Todd Zullinger]

lejeczek via users wrote:
>  On 08/06/18 16:39, Todd Zullinger wrote:
> > lejeczek via users wrote:
> >> how do you pass vars to rpmbuild for definition? eg
> >> 
> >> rpmbuild --define \'"${_definition2}"\'
> >> 
> >> I've been fiddling with ways to escape, but none is fricking working..
> >> I mean, rpmbuild rushes to work(no errors nor failure) so if you try just
> >> command line do not believe it, because later as it executes %if you will
> >> see process does not see these definitions.
> > The format would be --define '_definition2 value'.  The you
> > would use %{_definition2} in your spec file, (which I'm
> > presuming you already have, it's just not being defined).
> > 
> > The man page explains is this way:
> > 
> >      -D, --define='MACRO EXPR'
> >              Defines MACRO with value EXPR.
> > 
> > 
>  
>  Try to pass bash var to rpmbuild, eg:
>  
>  $ _def1="_me 1"
>  $ rpmbuild --define=${_def1}
>  
>  %if does not seem to catch/see these definitions. Like I said rpmbuild will
>  run but you should see it is not there as .spec gets digested & processed. 
It's hard to guess what error you get since you have not
included the output or a more complete example.  But my
guess is that you've not quoted the variable you're passing
to --define.  Here's an example spec and some example
output:

$ cat test.spec
Name:       test
Version:    1.0
Release:    1%{?dist}
Summary:    Test spec
License:        MIT

%description
%{summary}.

%prep
%if 0%{?_me}
echo "_me == %{_me}"
%else
echo "_me != 1"
%endif

#
# Running without --define shows the %else clause is reached
#
$ rpmbuild -bp test.spec 
Executing(%prep): /bin/sh -e /home/tmz/src/packages/tmp/rpm-tmp.po8R74
+ umask 022
+ cd /home/tmz/src/packages/test
+ echo '_me != 1'
_me != 1
+ exit 0

#
# Running with --define unquoted shows a failure
#
$ (_def1="_me 1"; rpmbuild -bp --define=$_def1 test.spec)
error: Macro %_me has empty body

#
# Running with --define quoted shows the %if clause is reached
#
$ (_def1="_me 1"; rpmbuild -bp --define="$_def1" test.spec)
Executing(%prep): /bin/sh -e /home/tmz/src/packages/tmp/rpm-tmp.jcPyKb
+ umask 022
+ cd /home/tmz/src/packages/test
+ echo '_me == 1'
_me == 1
+ exit 0

If you're experiencing some other sort of failure, it would
be useful if you included a shortened spec file and the
rpmbuild commands and output.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Honesty may be the best policy, but it's important to remember that
apparently, by elimination, dishonesty is the second-best policy.
    -- George Carlin

[lejeczek]

I'm sorry, I do not get it.. was I so hard to read?

$ _def1="_me 1"
$ rpmbuild --define \'"${_def1}"\'

and no matter how I quote, how I escape bash's var, rpmbuild does not 
"react" to it. I run it from a bash script.
I should mention I'm on Centos 7.5. RPM version 4.11.3

many thanks, L.

[Todd Zullinger]

lejeczek via users wrote:
>  I'm sorry, I do not get it.. was I so hard to read?
>  
>  $ _def1="_me 1"
>  $ rpmbuild --define \'"${_def1}"\'
>  
>  and no matter how I quote, how I escape bash's var, rpmbuild does not
>  "react" to it. I run it from a bash script.
>  I should mention I'm on Centos 7.5. RPM version 4.11.3 
Yes, it's good to know that you're on CentOS which uses an
older version of rpm.  That's not likely the issue here, but
it's sometimes the details which make all the difference.

More importantly, things we are still missing include:

    - an example spec file (or at least the parts where you
      define the macro and use them)

    - the output you get (including the commands you run to
      get them)

    - how that differs from the output you expect.

I included a simplified spec file and commands which showed
the output when run.  How does your spec file differ from
that example in the usage of the macros and %if statements?

We can help, but we need more information in order to do so.

I suspect that your issue is in how you're trying to create
and call the rpmbuild command from your shell script, which
is why you're showing so many levels of quoting.

But we shouldn't have to guess at this, you should provide
clear steps to demonstrate the issue, what the actual output
is, and what you expect it to be.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
If quizzes are quizzical, what are tests?

[lejeczek]

On 11/06/18 17:07, lejeczek via users wrote:
>  I'm sorry, I do not get it.. was I so hard to read?
>  
>  $ _def1="_me 1"
>  $ rpmbuild --define \'"${_def1}"\'
>  
>  and no matter how I quote, how I escape bash's var, rpmbuild does not 
>  "react" to it. I run it from a bash script.
>  I should mention I'm on Centos 7.5. RPM version 4.11.3
>  
>  many thanks, L.
>  _______________________________________________
>  users mailing list -- users(a)lists.fedoraproject.org
>  To unsubscribe send an email to users-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives: 
>
> https://lists.fedoraproject.org/archives/list/[e-mail].o...
>
>   
It actually might be working. What I was doing I was looking for a 
confirmation like this:

$ ps -FC rpmbuild --cols 9999
UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
appmgr   24855 24835  0 44512  6772  16 17:33 pts/0    00:00:00 rpmbuild 
--define "_MKL 1" --define "_mic 1"

waiting to see those quotation marks(single or double) in there, but.. 
it turns out that it works actually when ps is not showing them, like:

$ ps -FC rpmbuild --cols 9999
UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
appmgr   24855 24835  0 44512  6772  16 17:33 pts/0    00:00:00 rpmbuild 
--define _MKL 1 --define _mic 1

and then vars(in a bash script, all in such a script) are simply declared:
...
export _definition1='_MKL 1'
rpmbuild --define "${_definition1}" --define "${_definition2}"

without! any escaping of quotes.

[Todd Zullinger]

lejeczek via users wrote:
>  It actually might be working. What I was doing I was looking for a
>  confirmation like this:
>  
>  $ ps -FC rpmbuild --cols 9999
>  UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
>  appmgr   24855 24835  0 44512  6772  16 17:33 pts/0    00:00:00 rpmbuild
>  --define "_MKL 1" --define "_mic 1"
>  
>  waiting to see those quotation marks(single or double) in there, but.. it
>  turns out that it works actually when ps is not showing them, like:
>  
>  $ ps -FC rpmbuild --cols 9999
>  UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
>  appmgr   24855 24835  0 44512  6772  16 17:33 pts/0    00:00:00 rpmbuild
>  --define _MKL 1 --define _mic 1 
Ahh, yes.  There's a level of quoting needed by the shell,
which is removed when the command is executed and shows up
in ps.

>  and then vars(in a bash script, all in such a script) are simply
> declared:
>  ...
>  export _definition1='_MKL 1'
>  rpmbuild --define "${_definition1}" --define "${_definition2}"
>  
>  without! any escaping of quotes. 
It's not clear how you're using these macros, but if you're
toggling settings, the %bcond_with and %bcond_without
options may be useful.  Then you can enable/disable using
--with and --without on the rpmbuild command line.

http://rpm.org/user_doc/conditional_builds.html

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Experience is the worst teacher: it gives the test before presenting
the lesson.
    -- Vernon Law