[fedora-websites] Issue #1045: start.fp.o parses the Magazine RSS feed incorrectly when an article has embedded video

[Ben Cotton]

bcotton reported a new issue against the project: `fedora-websites` that you are
following:
``
The magfeed.py script blindly takes the first `<enclosure>` element to use as the
thumbnail for start.fedoraproject.org. This is fine in most cases, but if the article has
embedded video, we end up with a blank thumbnail. The RSS feed in that case contains
multiple enclosure elements and the featured image is listed last.

    <enclosure
url="https://fedoramagazine.org/wp-content/uploads/2020/06/Screencas...
length="410087" type="video/webm"/>
    <enclosure
url="https://fedoramagazine.org/wp-content/uploads/2020/06/Screencas...
length="388173" type="video/webm"/>
    <enclosure
url="https://fedoramagazine.org/wp-content/uploads/2020/06/Screencas...
length="398605" type="video/webm"/>
    <enclosure
url="https://fedoramagazine.org/wp-content/uploads/2020/06/Screencas...
length="1964954" type="video/webm"/>
    <enclosure
url="https://fedoramagazine.org/wp-content/uploads/2020/07/networkan...
length="36634" type="image/jpg"/>

We want it to only use enclosures with a type of `"image/jpg"` (note that the
RSS feed uses this type for both jpg and png images) to prevent this.

``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-websites/issue/1045

[Vinay Deshmukh]

vinaydeshmukh added a new comment to an issue you are following:
``
Hello, I am new to open source contribution, and I would like to work on solving this
issue.

``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-websites/issue/1045

[Ben Cotton]

The issue: `start.fp.o parses the Magazine RSS feed incorrectly when an article has
embedded video` of project: `fedora-websites` has been assigned to `jakfrost` by bcotton.

https://pagure.io/fedora-websites/issue/1045

[Ben Cotton]

bcotton added a new comment to an issue you are following:
``
Beginning with this morning's article, the magfeed script is failing on parsing the
Fedora Magazine RSS feed.

~~~~
start.fedoraproject.org build failed
====================================
python2.7 /srv/web/fedora-websites/start.fedoraproject.org/../build.d/build.py -o out -s
static -b /
Caching Magazine Feed...
python2.7 /srv/web/fedora-websites/start.fedoraproject.org/build/magfeed.py -o out -s
static -b /
Traceback (most recent call last):
  File "/srv/web/fedora-websites/start.fedoraproject.org/build/magfeed.py", line
25, in <module>
    if image_enclosure['type'] == 'image/jpg':
  File "/usr/lib/python2.7/site-packages/feedparser.py", line 375, in
__getitem__
    return dict.__getitem__(self, key)
KeyError: 'type'
make: *** [rss-cache] Error 1
~~~~

The RSS output contains an `audio/ogg` enclosure, which is maybe causing the problem? Or
is maybe a red herring?

~~~
<enclosure url="https://gathman.org/music/ogg/LUX%20MIX_1.ogg"
length="2191823" type="audio/ogg"/>
~~~
``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-websites/issue/1045

[Rick Elrod]

codeblock added a new comment to an issue you are following:
``
The line in question is:

```python
            if image_enclosure['type'] == 'image/jpg':
                break
```

Guessing we can probably replace it with:

```python
            if image_enclosure.get('type') == 'image/jpg':
                break
```
``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-websites/issue/1045

[Ben Cotton]

bcotton added a new comment to an issue you are following:
``
Made the [change suggested by
@codeblock](https://pagure.io/fedora-websites/issue/1045#comment-671643). I can't
reproduce the failure locally, so we'll test it in production. 🤷
``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-websites/issue/1045

[Ben Cotton]

The status of the issue: `start.fp.o parses the Magazine RSS feed incorrectly when an
article has embedded video` of project: `fedora-websites` has been updated to: Closed as
Fixed by bcotton.

https://pagure.io/fedora-websites/issue/1045

[Ben Cotton]

bcotton added a new comment to an issue you are following:
``
Looks like that fixed the glitch! Closing this issue
``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-websites/issue/1045