CSS problem on wiki

[Paul W. Frields]

https://fedoraproject.org/wiki/User:Pfrields/Outline_test

The page shows the problem, at least in my browser.  I have extensions
disabled and the CSS is rendering third-level headings as inline
elements instead of block.

[Al Thomas]

Well the markup looks a bit messy and over complicated - linking to eight 
external stylesheets!, but

/static/css/fedora.css

could be the cause. The headings are H3 element and this file has:

#content h3
{
  color: #337acc;
  margin: 1.5ex 0 0.5ex;
  font-size: 1.4em;
  display: inline-block; /* to put icons next to header */
}

You could try removing display: inline-block and see what impact it has across 
the site. I guess fedoraproject.org may also use /static/css/fedora.css as well 
though.

----- Original Message ----
> From: Paul W. Frields 
> To: Fedora Websites Team 
> Sent: Mon, 26 July, 2010 21:46:47
> Subject: CSS problem on wiki
>
> https://fedoraproject.org/wiki/User:Pfrields/Outline_test
>
> The page  shows the problem, at least in my browser.  I have extensions
> disabled  and the CSS is rendering third-level headings as inline
> elements instead of  block.
>
> -- 
> Paul W. Frields                                 http://paul.frields.org/
>   gpg fingerprint: 3DA6 A0AC 6D58 FEC4  0233  5906 ACDB C937 BD11 3717
>   http://redhat.com/   -  -  -  -  http://pfrields.fedorapeople.org/
>            Where open source multiplies: http://opensource.com
> -- 
> websites mailing list
> [e-mail]
> https://admin.fedoraproject.org/mailman/listinfo/websites

[Sijis Aviles]

On Mon, Jul 26, 2010 at 3:46 PM, Paul W. Frields  wrote:
> https://fedoraproject.org/wiki/User:Pfrields/Outline_test
>
> The page shows the problem, at least in my browser.  I have extensions
> disabled and the CSS is rendering third-level headings as inline
> elements instead of block.
>
> --
> Paul W. Frields                                http://paul.frields.org/
>  gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233  5906 ACDB C937 BD11 3717
>  http://redhat.com/   -  -  -  -   http://pfrields.fedorapeople.org/
>          Where open source multiplies: http://opensource.com
> --
> websites mailing list
> [e-mail]
> https://admin.fedoraproject.org/mailman/listinfo/websites

You are right. This is due to the fedora.css inheritance on fp.o. In
fedora.css, line 151 says "display: block-inline" and that's to allow
the most-compatible/fedora-default text to work.

In either case, this commit in fedora-web "52ad4f79" breaks it.

In most cases, i don't think there will be multiple h3's in a row
without text in between it.
Either way, it should be fixed. I'll add a class to that
most-compatible/fedora default text and tag block:display-inline to
that.

Sijis

[Sijis Aviles]

On Mon, Jul 26, 2010 at 4:11 PM, Sijis Aviles  wrote:
> On Mon, Jul 26, 2010 at 3:46 PM, Paul W. Frields  wrote:
> > https://fedoraproject.org/wiki/User:Pfrields/Outline_test
> >
> > The page shows the problem, at least in my browser.  I have extensions
> > disabled and the CSS is rendering third-level headings as inline
> > elements instead of block.
> >
> > --
> > Paul W. Frields                                http://paul.frields.org/
> >  gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233  5906 ACDB C937 BD11 3717
> >  http://redhat.com/   -  -  -  -   http://pfrields.fedorapeople.org/
> >          Where open source multiplies: http://opensource.com
> > --
> > websites mailing list
> > [e-mail]
> > https://admin.fedoraproject.org/mailman/listinfo/websites
>
> You are right. This is due to the fedora.css inheritance on fp.o. In
> fedora.css, line 151 says "display: block-inline" and that's to allow
> the most-compatible/fedora-default text to work.
>
> In either case, this commit in fedora-web "52ad4f79" breaks it.
>
> In most cases, i don't think there will be multiple h3's in a row
> without text in between it.
> Either way, it should be fixed. I'll add a class to that
> most-compatible/fedora default text and tag block:display-inline to
> that.
>
> Sijis

I'm attaching the patch.

Let me know if this works OK and doesn't break fp.o or wiki before committed.

Thanks,

Sijis

[Ian Weller]

On Mon, Jul 26, 2010 at 04:40:29PM -0500, Sijis Aviles wrote:
> I'm attaching the patch.
>
> Let me know if this works OK and doesn't break fp.o or wiki before committed.

+1

[Sijis Aviles]

On Mon, Jul 26, 2010 at 5:15 PM, Ian Weller  wrote:
> On Mon, Jul 26, 2010 at 04:40:29PM -0500, Sijis Aviles wrote:
> > I'm attaching the patch.
> >
> > Let me know if this works OK and doesn't break fp.o or wiki before committed.
>
> +1
>
> --
> Ian Weller 
> Where open source multiplies: http://opensource.com

I pushed the change about 30 minutes ago. Paul's test page works and
get.fp.o pages still work too. This appears to be fixed now.

Sijis