Using "Open location" in GIMP causes a (sometimes) catastrophic crash

[Artur Frenszek-Iwicki]

Recently I tried to edit some image from the internet in GIMP. Pressing "open image
in new tab" in Firefox yielded a "data:image/svg+xml;base64..." link. Being
a lazy person, instead of saving the image to disk, I selected "open location"
in GIMP and pasted the link there. Next thing I know, there's some fireworks.

I spun up a clean Fedora 34 VM to try to replicate this, and here's my observations:

1. Gnome on Wayland: GIMP crashes and that seems to be the end of it.

2. Gnome on X11: GIMP crashing brings down the Gnome panel (taskbar, whatever you want to
call it) along with it. The latter auto-restarts. Other programs are unaffected.

3. Cinnamon: GIMP does not crash, instead it displays a gargantuan (over 5000 pixels wide)
error message window. Moving this window around causes Cinnamon to crash. It then
auto-restarts... but, amusingly, apart from Cinnamon, Openbox starts up as well. (Should
someone try reproducing this - by default, both the Cinnamon and Openbox panels appear on
the bottom of the screen, so the Openbox panel won't be visible. Just move the
Cinnamon panel to another edge of the screen.) GIMP survives this, and other programs are
unaffected.

4. KDE Plasma on Wayland: the gigantic error message appears, but instead of rendering the
text, it's just a big black rectangle on the screen. However, GIMP does not crash.
Other programs seem unaffected.

5. KDE Plasma on X11: as above, but the error message window doesn't render at all. It
is there, it takes input, you can alt+tab to and away from it, but it's not visible.

6. XFCE: GIMP crashes and that's the end of it.

7. MATE: GIMP crashes and other program windows jump around on the screen for a short
while. Afterwards, things seem to work fine, but every window renders with a
several-pixels wide black border around it.

8. LXQt: GIMP crashes and brings down the LXQt panel with it. The latter does *NOT*
auto-restart. Other programs stop reacting to keyboard input. This effectively locks one
in the desktop session (short of switching to a TTY).

9. Openbox: the whole session crashes, bringing you back to the display manager's
login screen.

The base64 image is too big to put it in an e-mail, so I attach it as a link:
https://suve.fedorapeople.org/2021-06-18-gimpcrash-image-base64.txt
I have not tested whether other base64-encoded SVG images cause similar issues, or if
it's only this one.

I'm not sure if this a bug in GIMP, or in poor old Xorg, so that's why I decided
to post an e-mail here, instead of going straight to bugzilla.
Should anyone try to dig into this, let me know if you need a core dump or something.

A.FI.

[Josef Řídký]

Well, it would be great to get even terminal output from GIMP, if possible
(save it and then use 'gimp --verbose file-name').

Based on the txt file, it looks like it should be originally SVG file, in
that case, GIMP is able to open SVG file, but it make raster out of it, so
could be handy to see, if Inkscape is able to open such file, cause there
can be some issue in SVG processing or even anywhere else.

Are you able to provide a link to the original image?

Best regards

Josef Ridky
Senior Software Engineer
Core Services Team
Red Hat Czech, s.r.o.


On Fri, Jun 18, 2021 at 12:43 PM Artur Frenszek-Iwicki <
suve(a)fedoraproject.org&gt; wrote:

>  Recently I tried to edit some image from the internet in GIMP.
> Pressing
>  "open image in new tab" in Firefox yielded a
> "data:image/svg+xml;base64..."
>  link. Being a lazy person, instead of saving the image to disk, I selected
>  "open location" in GIMP and pasted the link there. Next thing I know,
>  there's some fireworks.
>
>  I spun up a clean Fedora 34 VM to try to replicate this, and here's my
>  observations:
>
>  1. Gnome on Wayland: GIMP crashes and that seems to be the end of it.
>
>  2. Gnome on X11: GIMP crashing brings down the Gnome panel (taskbar,
>  whatever you want to call it) along with it. The latter auto-restarts.
>  Other programs are unaffected.
>
>  3. Cinnamon: GIMP does not crash, instead it displays a gargantuan (over
>  5000 pixels wide) error message window. Moving this window around causes
>  Cinnamon to crash. It then auto-restarts... but, amusingly, apart from
>  Cinnamon, Openbox starts up as well. (Should someone try reproducing this -
>  by default, both the Cinnamon and Openbox panels appear on the bottom of
>  the screen, so the Openbox panel won't be visible. Just move the Cinnamon
>  panel to another edge of the screen.) GIMP survives this, and other
>  programs are unaffected.
>
>  4. KDE Plasma on Wayland: the gigantic error message appears, but instead
>  of rendering the text, it's just a big black rectangle on the screen.
>  However, GIMP does not crash. Other programs seem unaffected.
>
>  5. KDE Plasma on X11: as above, but the error message window doesn't
>  render at all. It is there, it takes input, you can alt+tab to and away
>  from it, but it's not visible.
>
>  6. XFCE: GIMP crashes and that's the end of it.
>
>  7. MATE: GIMP crashes and other program windows jump around on the screen
>  for a short while. Afterwards, things seem to work fine, but every window
>  renders with a several-pixels wide black border around it.
>
>  8. LXQt: GIMP crashes and brings down the LXQt panel with it. The latter
>  does *NOT* auto-restart. Other programs stop reacting to keyboard input.
>  This effectively locks one in the desktop session (short of switching to a
>  TTY).
>
>  9. Openbox: the whole session crashes, bringing you back to the display
>  manager's login screen.
>
>  The base64 image is too big to put it in an e-mail, so I attach it as a
>  link: https://suve.fedorapeople.org/2021-06-18-gimpcrash-image-base64.txt
>  I have not tested whether other base64-encoded SVG images cause similar
>  issues, or if it's only this one.
>
>  I'm not sure if this a bug in GIMP, or in poor old Xorg, so that's why I
>  decided to post an e-mail here, instead of going straight to bugzilla.
>  Should anyone try to dig into this, let me know if you need a core dump or
>  something.
>
>  A.FI.
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>  Do not reply to spam on the list, report it:
>  https://pagure.io/fedora-infrastructure
>

[Artur Frenszek-Iwicki]

>  Well, it would be great to get even terminal output from GIMP...
Terminal output under MATE (where GIMP crashes):

------- start
(gimp:7907): Gdk-WARNING **: 13:23:36.694: Native Windows wider or taller than 32767
pixels are not supported
 
(gimp:7907): Gdk-ERROR **: 13:23:36.817: The program 'gimp' received an X Window
System error.
This probably reflects a bug in the program.
The error was 'BadAlloc (insufficient resources for operation)'.
  (Details: serial 11413 error_code 11 request_code 53 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
 
(script-fu:7925): LibGimpBase-WARNING **: 13:23:37.602: script-fu: gimp_wire_read():
error
Trace/breakpoint trap (core dumped)
-------- end

On KDE, where GIMP does not crash, only the first warning about big native windows
appears.
Using "--verbose" when launching GIMP produces a lot of startup info, but does
not generate any extra messages once I try to open the link.

>  Are you able to provide a link to the original image? 
The image
is embedded in the website's HTML as that "data:image/svg` link I copied into the
.txt file. There's no canonical .svg.
Still, if you want to take a look at the original site, it's this one:
https://open.pl
The image in question is the small "open finance" company logo near the top
(hidden on the "mobile" layout).

A.FI.

[Josef Řídký]

Thanks for the information.

I've tried to download and open the OpenFinance company logo in GIMP on F34
(GNOME, XOrg) and all works as expected. The GIMP opens the import window
and proceeds normally.

What version/type of GIMP are you using? (rpm -q gimp)

Best regards

Josef Ridky
Senior Software Engineer
Core Services Team
Red Hat Czech, s.r.o.


On Fri, Jun 18, 2021 at 1:34 PM Artur Frenszek-Iwicki <
suve(a)fedoraproject.org&gt; wrote:

>  > Well, it would be great to get even terminal output from
> GIMP...
>  Terminal output under MATE (where GIMP crashes):
>
>  ------- start
>  (gimp:7907): Gdk-WARNING **: 13:23:36.694: Native Windows wider or taller
>  than 32767 pixels are not supported
>
>  (gimp:7907): Gdk-ERROR **: 13:23:36.817: The program 'gimp' received an X
>  Window System error.
>  This probably reflects a bug in the program.
>  The error was 'BadAlloc (insufficient resources for operation)'.
>    (Details: serial 11413 error_code 11 request_code 53 minor_code 0)
>    (Note to programmers: normally, X errors are reported asynchronously;
>     that is, you will receive the error a while after causing it.
>     To debug your program, run it with the --sync command line
>     option to change this behavior. You can then get a meaningful
>     backtrace from your debugger if you break on the gdk_x_error()
>  function.)
>
>  (script-fu:7925): LibGimpBase-WARNING **: 13:23:37.602: script-fu:
>  gimp_wire_read(): error
>  Trace/breakpoint trap (core dumped)
>  -------- end
>
>  On KDE, where GIMP does not crash, only the first warning about big native
>  windows appears.
>  Using "--verbose" when launching GIMP produces a lot of startup info, but
>  does not generate any extra messages once I try to open the link.
>
>  > Are you able to provide a link to the original image?
>  The image is embedded in the website's HTML as that "data:image/svg` link
>  I copied into the .txt file. There's no canonical .svg.
>  Still, if you want to take a look at the original site, it's this one:
>  https://open.pl
>  The image in question is the small "open finance" company logo near the
>  top (hidden on the "mobile" layout).
>
>  A.FI.
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>  Do not reply to spam on the list, report it:
>  https://pagure.io/fedora-infrastructure
>

[Artur Frenszek-Iwicki]

>  I've tried to download and open... 
When I use RMB ->
"Save image as" in Firefox, and then open the downloaded .svg in GIMP,
everything works fine.
The crash only happens when I take the "data:image/svg..." string and use
"Open location" in GIMP.

>  What version/type of GIMP are you using? (rpm -q gimp) 
Both my
host machine where I originally encountered this, and the VM I spun up to replicate the
issue, use gimp-2.10.24-1.fc34.x86_64.

A.FI.

[Josef Řídký]

Ok, I think I got it now. So first of all, the 'Open location' option in
GIMP expects a valid URI address - path to some local/network file (which
the data:image/svg... string is not).

From my point of view, it's ok, if the GIMP ends with an error message
explaining something like - No such file. This is actually written in the
super long alert window that pops up.

What is not so good are the cases, when GIMP crashes. They might be caused
by limited system resources. From the provided error message it looks like
insufficient RAM/buffer size.

So my recommendation would be to check the system resources status and use
GIMP options as expected.

Best regards

Josef Ridky
Senior Software Engineer
Core Services Team
Red Hat Czech, s.r.o.


On Fri, Jun 18, 2021 at 2:28 PM Artur Frenszek-Iwicki <
suve(a)fedoraproject.org&gt; wrote:

>  > I've tried to download and open...
>  When I use RMB -> "Save image as" in Firefox, and then open the downloaded
>  .svg in GIMP, everything works fine.
>  The crash only happens when I take the "data:image/svg..." string and use
>  "Open location" in GIMP.
>
>  > What version/type of GIMP are you using? (rpm -q gimp)
>  Both my host machine where I originally encountered this, and the VM I
>  spun up to replicate the issue, use gimp-2.10.24-1.fc34.x86_64.
>
>  A.FI.
>  _______________________________________________
>  devel mailing list -- devel(a)lists.fedoraproject.org
>  To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org
>  Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  https://lists.fedoraproject.org/archives/list/[e-mail]
>  Do not reply to spam on the list, report it:
>  https://pagure.io/fedora-infrastructure
>

[Björn Persson]

Josef Řídký wrote:
>  From my point of view, it's ok, if the GIMP ends with an error
> message
>  explaining something like - No such file. This is actually written in the
>  super long alert window that pops up.
>  
>  What is not so good are the cases, when GIMP crashes. They might be caused
>  by limited system resources. From the provided error message it looks
>  like insufficient RAM/buffer size. 
Perhaps limiting the length of the error message could prevent overuse
of system resources? I doubt anyone actually wants a super-wide alert
window.

Björn Persson