[Bug 461139] Review Request: Thabit-fonts from Arabeyes.org
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461139
Nicolas Mailhot <nicolas.mailhot(a)laposte.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |besfahbo(a)redhat.com
AssignedTo|nobody(a)fedoraproject.org |nicolas.mailhot(a)laposte.net
Flag| |fedora-review?,
| |needinfo?(440volt.tux@gmail
| |.com)
--- Comment #23 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> 2008-10-26 08:26:27 EDT ---
I wanted to wait for a submission with a fixed name, but since I'm doing a font
review run today anyway, here is a full review.
(on http://subhodip.fedorapeople.org/Thabit-fonts-0.02-3.fc9.src.rpm)
1. Please rename package to arabeyes-thabit-fonts
2. You have a typo in Summary
3. Is upstream's URL http://www.arabeyes.org/ or
http://www.arabeyes.org/project.php?proj=Khotot (as referenced in the README) ?
4. Is the description still ok for a Thabit-only package?
5. It's harmless, but a Source2 without Source1 is strange, especially on a new
package
6. Please use normal %setup macro in your package. That will simplify the spec
a lot (your complex manual unpacking was only necessary because you initially
tried to stuff two fonts in a single package)
7. Since upstream uses fontforge for building, please ask upstream to publish
sfd sources and build fedora fonts from those sources (we have many packages
that do so, for example DejaVu, Liberation, Inconsolata, etc)
8. Some people want all Fedora-added source files in a package to be prefixed
with the package name. You don't follow this convention for your fontconfig
file. Please use %{name}-fontconfig.conf as suggested by
http://fedoraproject.org/wiki/Packaging/FontsSpecTemplate
9. I don't know if 65 is the right fontconfig priority for this font. You need
to discuss it with Behdad (preferably CC-ing the fedora fonts list)
10. Please only declare thabit-related fontconfig rules in the fontconfig file
shipped with the thabit package
11. You probably want a "Generic name" rule in addition to the "Registering a
font in default families" rule in your fontconfig file
→ http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Generic_names
This rule is used by fontconfig to complete your font with glyphs from other
fonts when it encounters a codepoint your font is missing
→
http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Registering_a_fon...
This rule is used by fontconfig to identify what fonts to use when an
application requests a "cursive" font.
12. Please reformat your xml files with xmllint --format before submission so
they are nicely indented with the same rules as other font packages
13. When you've written fontconfig rules you're happy with it's always a good
idea to send them upstream to be included in the font next releases (in the
versionned source archive you're supposed to request)
14. You can drop the -f flag to fc-cache for releases ≥ Fedora 9
15. OFL.txt mentions an IBM copyright. Please ask upstream to add a Fontlog.txt
to their source release archive (as recommended by SIL for OFL fonts), that
clearly identifies what other fonts were used to create this font, so Fedora
Legal can check there is no problem
16. Please make sure all the steps up to 2.a (included) have been followed in
https://fedoraproject.org/wiki/Font_package_lifecycle
In particular we need a wiki page that describes the font to be added to the
wiki (for release notes)
Well that's a lot of stuff to fix and it's a pity the OLPC folks didn't do a
full review before accepting this font package. I'm putting a "NEEDINFO
reporter" on this bug and the Mothanna one (since it needs more or less the
same fixes). Please remove this flag once you've fixed the previous points.
Please don't hesitate to ask questions on the fedora fonts list if there are
elements you need help with.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 8 months
[Bug 466193] Review Request: alee-fonts - Korean TrueType Fonts
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466193
Nicolas Mailhot <nicolas.mailhot(a)laposte.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tcallawa(a)redhat.com
AssignedTo|nobody(a)fedoraproject.org |nicolas.mailhot(a)laposte.net
Flag| |fedora-review?,
| |needinfo?(smallvil(a)get9.net
| |)
--- Comment #3 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> 2008-10-26 07:37:15 EDT ---
Setting needinfo till the requested changes are done. Please remove the flag
when the next version of the spec is ready
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 8 months
[Bug 467507] Review Request: Rufscript-fonts - Rufscripts is a decorative handwriting based font
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467507
Nicolas Mailhot <nicolas.mailhot(a)laposte.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-review?,
| |needinfo?(sundaram(a)redhat.c
| |om)
--- Comment #2 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> 2008-10-26 07:28:20 EDT ---
1. Since Minto Joseph and you are both packaging Hiran's fonts, you should get
together and interact with Hiran collectively (see bug #457709).
2. It's not a good idea to keep the versioning in the TTF filename, some apps
refer fonts by filename and will get cross with you if it changes every version
3. You should discuss with Minto if you want to adopt a common prefix for your
font packages names (for example hiranv-rufscript-fonts and
perizia-rufscript-fonts). We've more or less started to do it for big foundries
(gfs, sil) and some individual font authors (thibault), it's probably better to
generalise the convention to have consistent naming
(please subscribe to the fonts SIG list if you haven't done so yet to get
informed of packaging convention evolutions)
4. you can drop the -f in the fc-cache invocation for releases ≥ Fedora 9
→ http://fedoraproject.org/wiki/Packaging/FontsSpecTemplate
5. Some people want all Fedora-added source files in a package to be prefixed
with the package name. You don't follow this convention for your fontconfig
file. Please take inspiration from the general packaging guidelines or Minto's
package to fix it.
→ http://fedoraproject.org/wiki/Packaging/FontsSpecTemplate
→ bug #457709
6. 69 is a bit low, for a latin font like rufscript something between 62 and 64
would be fine
→ http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Simple_priority_l...
7. Please have upstream publish rufscript in a proper versioned archive with a
detached license file you can add in %doc
8. Please reformat your xml files with xmllint --format before submission so
they are nicely indented
9. I would have declared rufscript as a cursive font, not a sans-serif one
10. Please add a "Generic name" rule in addition to the "Registering a font in
default families" rule
→ http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Generic_names
This rule is used by fontconfig to complete your font with glyphs from other
fonts when it encounters a codepoint your font is missing
→
http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Registering_a_fon...
This rule is used by fontconfig to identify what fonts to use when an
application requests a "cursive" font.
11. When you've written fontconfig rules you're happy with it's always a good
idea to send them upstream to be included in the font next releases (in the
versionned archive you're supposed to request)
Despite the long todo list your spec is in good shape overall and it should not
take much to get it in a state that can be approved.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 8 months
[Bug 457709] Review Request: perizia-fonts - English asymmetric font
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457709
Nicolas Mailhot <nicolas.mailhot(a)laposte.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |
--- Comment #3 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> 2008-10-26 06:54:46 EDT ---
Lastly you should not touch the fedora-review flag. Setting it to ? basically
means you've committed to reviewing this package, which you can't (since you're
the packager), and thus you've deadlocked your own submission. Fixing.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 8 months
[Bug 455136] New: no fontconfig file in devel
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=455136
Summary: no fontconfig file in devel
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: low
Priority: low
Component: roadstencil-fonts
AssignedTo: jonstanley(a)gmail.com
ReportedBy: jonstanley(a)gmail.com
QAContact: extras-qa(a)fedoraproject.org
CC: fedora-fonts-bugs-list(a)redhat.com
There is no fontconfig file in devel
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
15 years, 8 months
[Bug 432184] The Visibone font test does not work with the icedtea java plugin
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=432184
--- Comment #5 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> 2008-10-25 08:58:39 EDT ---
$ firefox http://www.codestyle.org/css/font-family/AppletTest.shtml
ICEDTEAPLUGIN_DEBUG = (null)
Initializing JVM...
NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Start()
Oct 25, 2008 2:57:10 PM com.sun.corba.se.impl.ior.IORImpl getProfile
WARNING: "IOP00511201: (INV_OBJREF) IOR must have at least one IIOP profile"
org.omg.CORBA.INV_OBJREF: vmcid: SUN minor code: 1201 completed: No
at
com.sun.corba.se.impl.logging.IORSystemException.iorMustHaveIiopProfile(IORSystemException.java:473)
at
com.sun.corba.se.impl.logging.IORSystemException.iorMustHaveIiopProfile(IORSystemException.java:495)
at com.sun.corba.se.impl.ior.IORImpl.getProfile(IORImpl.java:334)
at
com.sun.corba.se.impl.encoding.CDRInputStream_1_0.read_Object(CDRInputStream_1_0.java:787)
at
com.sun.corba.se.impl.encoding.CDRInputStream_1_0.read_Object(CDRInputStream_1_0.java:761)
at
com.sun.corba.se.impl.encoding.CDRInputStream.read_Object(CDRInputStream.java:231)
at
com.sun.corba.se.impl.resolver.INSURLOperationImpl.getIORFromString(INSURLOperationImpl.java:120)
at
com.sun.corba.se.impl.resolver.INSURLOperationImpl.operate(INSURLOperationImpl.java:130)
at com.sun.corba.se.impl.orb.ORBImpl.string_to_object(ORBImpl.java:836)
at org.GNOME.Accessibility.AccessUtil.getRegistryObject(AccessUtil.java:143)
at
org.GNOME.Accessibility.JavaBridge.registerApplication(JavaBridge.java:1099)
at org.GNOME.Accessibility.JavaBridge.<init>(JavaBridge.java:364)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:532)
at java.lang.Class.newInstance0(Class.java:372)
at java.lang.Class.newInstance(Class.java:325)
at java.awt.Toolkit.loadAssistiveTechnologies(Toolkit.java:786)
at java.awt.Toolkit.getDefaultToolkit(Toolkit.java:874)
at java.awt.Window.getToolkit(Window.java:1170)
at java.awt.Window.init(Window.java:400)
at java.awt.Window.<init>(Window.java:438)
at java.awt.Frame.<init>(Frame.java:419)
at java.awt.Frame.<init>(Frame.java:384)
at sun.awt.EmbeddedFrame.<init>(EmbeddedFrame.java:102)
at sun.awt.EmbeddedFrame.<init>(EmbeddedFrame.java:99)
at sun.awt.EmbeddedFrame.<init>(EmbeddedFrame.java:87)
at sun.awt.X11.XEmbeddedFrame.<init>(XEmbeddedFrame.java:35)
at sun.applet.PluginAppletViewer.<init>(PluginAppletViewer.java:145)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:532)
at java.lang.Class.newInstance0(Class.java:372)
at java.lang.Class.newInstance(Class.java:325)
at sun.applet.PluginStreamHandler.<init>(PluginStreamHandler.java:43)
at sun.applet.PluginMain.connect(PluginMain.java:101)
at sun.applet.PluginMain.<init>(PluginMain.java:83)
at sun.applet.PluginMain.main(PluginMain.java:59)
Jar string: FontSurveyApplet.jar
jars length: 1/usr/lib64/firefox-3.0.2/run-mozilla.sh: line 131: 29827
Segmentation fault "$prog" ${1+"$@"}
$ JNLPRuntime already initialized
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 8 months