Re: Patch to move wiki button bar below text area
On 3/25/07, Mike McGrath <mmcgrath(a)redhat.com> wrote:
Dimitris Glezos wrote:
> Attaching a patch for Moin to move the wiki edit buttons under the comments,
> something some users have asked for.
>
> Of course this messes with the actual Moin code and will be re-written in case
> of an upgrade. Nevertheless, it might be worth it (besides, if we don't apply
> the patch after the upgrade, nothing breaks really).
>
> I've also created an upstream RFE:
>
> http://moinmoin.wikiwikiweb.de/FeatureRequests/MoveButtonBarBelowCommentBox
>
> -d
>
First off, I just want to say glezos is wiki-amazing :-). Beyond that I
wanted to state my concerns with this patch. If we can get this
incorporated upstream, I think it's great. If not my concern is ongoing
maintenance. It's never a fun thing to keep a local fork up to date.
I'll leave it entirely up to the websites team but I wanted to point out
that there are steep requirements long term with this patch which may
muck with future upgrades and I want to make sure everyone considers it
for an aesthetic change.
Though "not applying the patch if its broken" does kind of solve all of
these concerns :-)
-Mike
If this is the "Buttons Location" request I made in the past, I
definitely prefer them at the bottom rather than at the top. I believe
this is the way it was in the previous wiki.
http://fedoraproject.org/wiki/Infrastructure/WikiMigration
Regards,
--
Thomas Chung
http://fedoraproject.org/wiki/ThomasChung