Federico Simoncelli has uploaded a new change for review.
Change subject: Add a chown implementation that looks up uid and gid
......................................................................
Add a chown implementation that looks up uid and gid
We already have a case in vdsm (configNetwork) where we need to use
a chown function that is capable to convert the owner and group names
to uid and gid. Going forward this can be reused for the deployment
utilities and to prepare the paths needed by vdsm (eg: /rhev and
/var/run/vdsm).
Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555
---
M vdsm/configNetwork.py
M vdsm/utils.py
2 files changed, 21 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/387/1
--
To view, visit http://gerrit.ovirt.org/387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Add the base commands to vdsm-tool
......................................................................
[WIP] Add the base commands to vdsm-tool
Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e
---
M vdsm-tool/Makefile.am
A vdsm-tool/base.py
M vdsm.spec.in
3 files changed, 52 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/388/1
--
To view, visit http://gerrit.ovirt.org/388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
......................................................................
BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
Attempting to stop the SPM (SIGUSR1) and using SIGKILL if that fails is
already enough. In any case giving vdsm only 2 seconds between SIGTERM
and SIGKILL was a too short timeout to hope in a restart.
Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8
---
M vdsm/storage/protect/spmprotect.sh
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/265/1
--
To view, visit http://gerrit.ovirt.org/265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gal Hammer has uploaded a new change for review.
Change subject: Added a support for a guest hibernate command.
......................................................................
Added a support for a guest hibernate command.
Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
---
M vdsm/clientIF.py
M vdsm/guestIF.py
M vdsm_cli/vdsClient.py
3 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/1121/1
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Don't rotate core dump logs on Fedora
......................................................................
Don't rotate core dump logs on Fedora
Core dumps are a system-level configuration and VDSM shouldn't try to
override what the sysadmin decides.
Change-Id: I0a2e86614475fd13de3888b956b5512a24016281
---
M configure.ac
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/cdumps-logrotate.conf
A vdsm/vdsm-logrotate.conf
D vdsm/vdsm-logrotate.conf.in
6 files changed, 27 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/991/1
--
To view, visit http://gerrit.ovirt.org/991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a2e86614475fd13de3888b956b5512a24016281
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert "BZ#708779 - Avoid pools with mixed domain versions"
......................................................................
Revert "BZ#708779 - Avoid pools with mixed domain versions"
This reverts commit 017db3b2740a8c7d22c5366c70600eb47643e8ab.
We would like to allow upgrading a storage pool to new 3.0 format, and
to allow upgrading 2.2 domains automatically when they are attached to a
3.0-formatted pool.
Conflicts:
vdsm/storage/hsm.py
vdsm/storage/sp.py
Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm/storage/storage_exception.py
3 files changed, 12 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/753/1
--
To view, visit http://gerrit.ovirt.org/753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70023fe661bc6ab7bed54961c1a25ac0845e2018
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
New patch submitted by Igor Lvovsky (ilvovsky(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/692
commit 3a09f874889cb372ee84b04a234f7b653458e26f
Author: Igor Lvovsky <ilvovsky(a)redhat.com>
Date: Tue Jul 12 15:18:45 2011 +0300
Change getChain() to return dictionary with chain itself and its template.
This change will avoid unneeded produceVolume and improve
behaviour of different flows.
Change-Id: Ife46d592171aedea087e0d6462b735cd7e0d75e0
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 1c70a34..102ea6c 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -104,7 +104,7 @@ class Image:
# 1. Remove template's image: Create 'fake' template instead of deleted one
# 2. Remove regular image: Remove parent-'fake' template if nobody need it already
try:
- pvol = self.getTemplate(sdUUID=sdUUID, imgUUID=imgUUID)
+ pvol = self.getChain(sdUUID, imgUUID)['template']
# 1. If we required to delete template's image that have VMs
# based on it, we should create similar 'fake' template instead
if pvol:
@@ -269,17 +269,16 @@ class Image:
return newImgUUID
- def __chainSizeCalc(self, sdUUID, imgUUID, volUUID, size):
+ def __chainSizeCalc(self, sdUUID, imgUUID, size):
"""
Compute an estimate of the whole chain size
using the sum of the actual size of the chain's volumes
"""
- chain = self.getChain(sdUUID, imgUUID, volUUID)
+ chainDict = self.getChain(sdUUID, imgUUID)
newsize = 0
- template = chain[0].getParentVolume()
- if template:
- newsize = template.getVolumeSize()
- for vol in chain:
+ if chainDict['template']:
+ newsize = chainDict['template'].getVolumeSize()
+ for vol in chainDict['chain']:
newsize += vol.getVolumeSize()
if newsize > size:
newsize = size
@@ -301,12 +300,14 @@ class Image:
newsize = int(newsize * 1.1) # allocate %10 more for cow metadata
return newsize
- def getChain(self, sdUUID, imgUUID, volUUID=None):
+ def getChain(self, sdUUID, imgUUID):
"""
- Return the chain of volumes of image as a sorted list
- (not including a shared base (template) if any)
+ Return the dictionary with chain of volumes of image as a sorted list
+ (not including a shared base (template)) and the template if any
"""
- chain = []
+ # 'chain' - chain of volumes of image as a sorted list
+ # 'template' - shared base (template) if any
+ chainDict = {'chain':[], 'template':None}
# Find all volumes of image
volclass = SDF.produce(sdUUID).getVolumeClass()
uuidlist = volclass.getImageVolumes(self.repoPath, sdUUID, imgUUID)
@@ -316,14 +317,13 @@ class Image:
srcVol = volclass(self.repoPath, sdUUID, imgUUID, uuidlist[0])
# For template image include only one volume (template itself)
if len(uuidlist) == 1 and srcVol.isShared():
- return [srcVol]
+ return {'chain':[srcVol], 'template':srcVol}
# find the leaf
for vol in uuidlist:
srcVol = volclass(self.repoPath, sdUUID, imgUUID, vol)
if srcVol.isLeaf():
- if not volUUID or volUUID == srcVol.volUUID:
- break
+ break
srcVol = None
if not srcVol:
@@ -332,38 +332,25 @@ class Image:
# Build up the sorted (parent->child) chain
while not srcVol.isShared():
- chain.insert(0, srcVol)
+ chainDict['chain'].insert(0, srcVol)
if srcVol.getParent() == volume.BLANK_UUID:
break
srcVol = srcVol.getParentVolume()
- self.log.info("sdUUID=%s imgUUID=%s chain=%s ", sdUUID, imgUUID, str(chain))
- return chain
+ if srcVol.isShared():
+ chainDict['template'] = srcVol
- def getTemplate(self, sdUUID, imgUUID):
- """
- Return template of the image
- """
- tmpl = None
- # Find all volumes of image (excluding template)
- chain = self.getChain(sdUUID, imgUUID)
- # check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
- if pvol:
- tmpl = pvol
- elif chain[0].isShared():
- tmpl = chain[0]
-
- return tmpl
+ self.log.info("sdUUID=%s imgUUID=%s chainDict=%s ", sdUUID, imgUUID, str(chainDict))
+ return chainDict
def validate(self, srcSdUUID, dstSdUUID, imgUUID, op=MOVE_OP):
"""
Validate template on destination domain
"""
- # Find all volumes of source image
- chain = self.getChain(srcSdUUID, imgUUID)
- leafVol = chain[-1]
srcDom = SDF.produce(srcSdUUID)
+ # Find all volumes of source image
+ chainDict = self.getChain(srcSdUUID, imgUUID)
+ leafVol = chainDict['chain'][-1]
# Avoid move template's image if there is a VM based on it (except 'Backup' domain)
if op == MOVE_OP and leafVol.isShared() and not srcDom.isBackup():
chList = leafVol.getAllChildrenList(self.repoPath, srcSdUUID, imgUUID, leafVol.volUUID)
@@ -371,18 +358,16 @@ class Image:
raise se.MoveTemplateImageError(imgUUID)
# check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
+ pvol = chainDict['template']
if pvol: # this is a shared template based chain
- if not pvol.isShared():
- raise se.ImageIsNotLegalChain("Base image parent vol %s is not shared" % pvol.volUUID)
pimg = pvol.getImage() # pimg == template image
try:
volclass = SDF.produce(dstSdUUID).getVolumeClass()
# Validate that the destination template exists and accessible
volclass(self.repoPath, dstSdUUID, pimg, pvol.volUUID)
- except se.StorageException, e:
- self.log.error("Unexpected error", exc_info=True)
- raise se.CouldNotValideTemplateOnTargetDomain("Template %s Destination domain %s: %s" % (pimg, dstSdUUID, str(e)))
+ except se.StorageException:
+ self.log.error("Cannot validate template %s on target domain %s", pimg, dstSdUUID, exc_info=True)
+ raise se.CouldNotValideTemplateOnTargetDomain()
def __templateRelink(self, destDom, imgUUID, volUUID):
"""
@@ -473,20 +458,15 @@ class Image:
def _createTargetImage(self, destDom, srcSdUUID, imgUUID):
# Before actual data copying we need perform several operation
# such as: create all volumes, create fake template if needed, ...
- try:
- # Find all volumes of source image
- srcChain = self.getChain(srcSdUUID, imgUUID)
- except se.StorageException:
- self.log.error("Unexpected error", exc_info=True)
- raise
- except Exception, e:
- self.log.error("Unexpected error", exc_info=True)
- raise se.SourceImageActionError(imgUUID, srcSdUUID, str(e))
+
+ # Find all volumes of source image
+ srcChainDict = self.getChain(srcSdUUID, imgUUID)
+ srcChain = srcChainDict['chain']
fakeTemplate = False
pimg = volume.BLANK_UUID # standalone chain
# check if the chain is build above a template, or it is a standalone
- pvol = srcChain[0].getParentVolume()
+ pvol = srcChainDict['template']
if pvol:
# find out parent volume parameters
volParams = pvol.getVolumeParams()
@@ -686,11 +666,9 @@ class Image:
"""
if not self.isLegal(sdUUID, imgUUID):
raise se.ImageIsNotLegalChain(imgUUID)
- chain = self.getChain(sdUUID, imgUUID)
- # check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
- if pvol:
- if not pvol.isLegal() or pvol.isFake():
+ chainDict = self.getChain(sdUUID, imgUUID)
+ if chainDict['template']:
+ if not chainDict['template'].isLegal() or chainDict['template'].isFake():
raise se.ImageIsNotLegalChain(imgUUID)
def copy(self, sdUUID, vmUUID, srcImgUUID, srcVolUUID, dstImgUUID, dstVolUUID,
@@ -735,8 +713,7 @@ class Image:
# using the sum of the actual size of the chain's volumes
if volParams['volFormat'] != volume.COW_FORMAT or volParams['prealloc'] != volume.SPARSE_VOL:
raise se.IncorrectFormat(self)
- volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID,
- srcVolUUID, volParams['size'])
+ volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID, volParams['size'])
# Find out dest volume parameters
if preallocate in [volume.PREALLOCATED_VOL, volume.SPARSE_VOL]:
diff --git a/vdsm/storage/resourceFactories.py b/vdsm/storage/resourceFactories.py
index ce3ec70..07df0f0 100644
--- a/vdsm/storage/resourceFactories.py
+++ b/vdsm/storage/resourceFactories.py
@@ -106,20 +106,18 @@ class ImageResourceFactory(rm.SimpleResourceFactory):
# Get the list of the volumes
repoPath = os.path.join(self.storage_repository, dom.getPools()[0])
try:
- chain = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName)
+ chainDict = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName)
+ chain = chainDict['chain']
except se.ImageDoesNotExistInSD:
log.debug("Image %s does not exist in domain %s", resourceName, self.sdUUID)
return []
- # check if the chain is build above a template, or it is a standalone
- pvol = chain[0].getParentVolume()
- if pvol:
- template = pvol.volUUID
- elif chain[0].isShared():
- # Image of template itself,
- # with no other volumes in chain
- template = chain[0].volUUID
- del chain[:]
+ # Image of template itself,
+ # with no other volumes in chain
+ if chainDict['template']:
+ template = chainDict['template'].volUUID
+ if chainDict['template'] in chain:
+ del chain[:]
volUUIDChain = [vol.volUUID for vol in chain]
volUUIDChain.sort()
Federico Simoncelli has uploaded a new change for review.
Change subject: BZ#752470 Related: Out of process getReadDelay
......................................................................
BZ#752470 Related: Out of process getReadDelay
To avoid being blocked by a thread in a D state we should determine the
read delay using oop also for block devices.
Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e
---
M vdsm/storage/blockSD.py
M vdsm/storage/misc.py
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/264/1
--
To view, visit http://gerrit.ovirt.org/264
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#773210 - Avoid infinity loop when delete volume failed during the merge
......................................................................
BZ#773210 - Avoid infinity loop when delete volume failed during the merge
Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
---
M vdsm/storage/image.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/987/1
--
To view, visit http://gerrit.ovirt.org/987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Integrate SANLock with VM's life cycle
......................................................................
Integrate SANLock with VM's life cycle
Change-Id: I55596a7a5b25fded341f6157f190ae741af41fce
---
M vdsm/libvirtvm.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/sd.py
5 files changed, 78 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/1253/1
--
To view, visit http://gerrit.ovirt.org/1253
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55596a7a5b25fded341f6157f190ae741af41fce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] Support unicode in domain and pool description
......................................................................
[WIP] Support unicode in domain and pool description
Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e
---
M vdsm/storage/dispatcher.py
M vdsm/storage/persistentDict.py
M vdsm/storage/sd.py
M vdsm/storage/sp.py
4 files changed, 17 insertions(+), 31 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/637/1
--
To view, visit http://gerrit.ovirt.org/637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8fd0676ba263a66e54e8caecad6c76c001f7f3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: added support for mirror promisc mode
......................................................................
added support for mirror promisc mode
let ability to VM to monitor (mirror) all other VMs in the same host by
specific network (bridge)
Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
---
M configure.ac
M vdsm/libvirtvm.py
2 files changed, 123 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/956/1
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Roi Dayan has uploaded a new change for review.
Change subject: fixed iscsi discovery and added iSER transport support
......................................................................
fixed iscsi discovery and added iSER transport support
Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
---
M vdsm/config.py.in
M vdsm/storage/iscsi.py
2 files changed, 41 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/1350/1
--
To view, visit http://gerrit.ovirt.org/1350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie932ecd4b382aa99ef1bb20882ea44291ba39f47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roi Dayan <roi.dayan(a)gmail.com>
Gal Hammer has uploaded a new change for review.
Change subject: A new method to read from VMs' channels.
......................................................................
A new method to read from VMs' channels.
Replaced having a thread-per-VM that monitor and read from the
VM's virtual channel with a 1-thread listener that handle all
VMs' channels.
Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/clientIF.py
M vdsm/guestIF.py
M vdsm/libvirtvm.py
A vdsm/vmChannels.py
6 files changed, 164 insertions(+), 69 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/869/1
--
To view, visit http://gerrit.ovirt.org/869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Refactor storage connection subsystem
......................................................................
Refactor storage connection subsystem
The current one is an abysmal mess. This is a tramsitional patch
retrofitting the old API to some of the concept we intend to implement.
This introduces ConnectionMonitor. It currently doesn't do any
monitoring just connects and disconnects from storage. It uses URIs for
specifying storage targets which is more generic and simple to parse.
Notice:
Permissions are no longer checked on storage connect only on domain
initialization. This is good as the storage connection is far from an
apropriate place for that check.
I've removed stale root folder handling for NFS. I will add it back I
can't do everything at once.
There are also no proper engine acceptable exceptions yet
Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
---
M vdsm.spec.in
M vdsm/storage/Makefile.am
A vdsm/storage/connectionMonitor.py
M vdsm/storage/fileSD.py
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
M vdsm/storage/localFsSD.py
M vdsm/storage/misc.py
M vdsm/storage/mount.py
M vdsm/storage/multipath.py
M vdsm/storage/nfsSD.py
A vdsm/storage/storageMailbox.py
D vdsm/storage/storage_connection.py
A vdsm/storage/sync.py
14 files changed, 884 insertions(+), 486 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/1038/1
--
To view, visit http://gerrit.ovirt.org/1038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: [WIP] Move the VDSM common code to the python site lib
......................................................................
[WIP] Move the VDSM common code to the python site lib
Some VDSM code is shared between different components (eg: vdsm and
vdsm-cli share vdscli.py) and some modules have a really common name
(eg: utils, config) risking to collide with other packages.
For these two reasons and for cleanliness some modules are moved to
a new location (the standard python site lib) and they can be shipped
in a different package.
Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6
---
M configure.ac
M vds_bootstrap/vds_bootstrap.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/caps.py
M vdsm/clientIF.py
M vdsm/config.py
M vdsm/configNetwork.py
M vdsm/get-conf-item
M vdsm/guestIF.py
M vdsm/hooks.py
M vdsm/kaxmlrpclib.py
M vdsm/ksm.py
M vdsm/libvirtconnection.py
M vdsm/libvirtvm.py
M vdsm/netinfo.py
M vdsm/set-conf-item
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/devicemapper.py
M vdsm/storage/dispatcher.py
M vdsm/storage/fileSD.py
M vdsm/storage/fileUtils.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
M vdsm/storage/outOfProcess.py
M vdsm/storage/processPool.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/safelease.py
M vdsm/storage/sd.py
M vdsm/storage/sdc.py
M vdsm/storage/sp.py
M vdsm/storage/storage_connection.py
M vdsm/storage/storage_mailbox.py
M vdsm/storage/task.py
M vdsm/storage/taskManager.py
M vdsm/storage/volume.py
M vdsm/substitute_constants.py
M vdsm/supervdsm.py
M vdsm/supervdsmServer.py
M vdsm/ut/ivdsm.py
M vdsm/ut/testGuestChannel.py
M vdsm/utils.py
M vdsm/vdsm
M vdsm/vm.py
M vdsm_cli/Makefile.am
M vdsm_cli/dumpStorageTable.py
M vdsm_cli/vdsClient.py
M vdsm_cli/vdscli.py.in
M vdsm_hooks/faqemu/before_vm_start.py
M vdsm_hooks/vhostmd/after_vm_destroy.py
M vdsm_reg/rhevm.py
M vdsm_reg/vdsm-reg-setup
57 files changed, 144 insertions(+), 129 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/286/1
--
To view, visit http://gerrit.ovirt.org/286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Make validateStorageServerConnection API call a noop
......................................................................
Make validateStorageServerConnection API call a noop
This call is useless and slow. It check different things in different
levels for different storage types and does not guarantee a future
connect will succeed. Until someone actually defines what is actually
being validated (params? hostname? permissions? authentication tokens?)
I suggest to just disable this verb so it doesn't make any NFS
connection take twice as long and be exponentially more complex.
Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
---
M vdsm/storage/hsm.py
1 file changed, 4 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/1097/1
--
To view, visit http://gerrit.ovirt.org/1097
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia56e7bb5b3f725de8f9a8e4498c67ff20b83824b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: storagePool: Reject unknown method in uploadVolume
......................................................................
storagePool: Reject unknown method in uploadVolume
Address a previously identified TODO in the code and report an error if a method
other than 'wget' or 'rsync' is specified.
Change-Id: I35267fab74a98bab351e4e66b9349ded69c573ee
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/storage/sp.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/671/1
--
To view, visit http://gerrit.ovirt.org/671
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35267fab74a98bab351e4e66b9349ded69c573ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Eduardo has uploaded a new change for review.
Change subject: Revert "Fix getMasterDomain masterVersion handling"
......................................................................
Revert "Fix getMasterDomain masterVersion handling"
This reverts commit ce280b09c776b33203847dc7e7ad77ee90a34bc0.
masterVersion is an exclusive property of RHEV-m.
There are no RHEV-M flows that not send the expected version.
All VDSM flows should have an expected version.
Towards a masterVersion (>0) meaning a master domain and
removing redundant metadata fields as isMaster, etc.
Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/955/1
--
To view, visit http://gerrit.ovirt.org/955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46ba2bedbb0e0264454c75a8b08c1c67c98e02d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: added mtu support for network interface
......................................................................
added mtu support for network interface
Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
---
M vdsm/configNetwork.py
1 file changed, 107 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/754/1
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: [WIP] Adding flowID
......................................................................
[WIP] Adding flowID
This patch will implement the flowID schema. The idea is provide a
mechanism to identify the transactions between ovirt engine and vdsm.
Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f
---
M vdsm/clientIF.py
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/1221/1
--
To view, visit http://gerrit.ovirt.org/1221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c818d7a90fea41663fd48620ac9718451a8662f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Escape underscore as well
......................................................................
Escape underscore as well
This prevent collision between 'hello/world' and 'hello_world'
Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
---
M vdsm/storage/storageProviderConnectionMonitor.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/1245/1
--
To view, visit http://gerrit.ovirt.org/1245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id91c5837c0442d3fff2e18cdfccb68a51e08c848
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: [WIP] Implement an API call to retrieve storage connection state
......................................................................
[WIP] Implement an API call to retrieve storage connection state
Change-Id: Ife9b5a6db4a1c0c73b6d6dc079876d195a15c9fa
---
M vdsm/storage/hsm.py
M vdsm/storage/storageProviderConnectionMonitor.py
2 files changed, 241 insertions(+), 46 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/1250/1
--
To view, visit http://gerrit.ovirt.org/1250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife9b5a6db4a1c0c73b6d6dc079876d195a15c9fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Add __hash__() to all connection classes
......................................................................
Add __hash__() to all connection classes
Without it connections can't be keys of dicts
Change-Id: I56e5e2e53a60d50d88efc1a5540bf2136a6a81b6
---
M vdsm/storage/mount.py
M vdsm/storage/storageProviderConnectionMonitor.py
2 files changed, 29 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/1246/1
--
To view, visit http://gerrit.ovirt.org/1246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56e5e2e53a60d50d88efc1a5540bf2136a6a81b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Have wait return the value of the event
......................................................................
Have wait return the value of the event
Change-Id: I6ef5fb239be47714e0cebf4ce5c0ebf790384b79
---
M vdsm/storage/sync.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/1247/1
--
To view, visit http://gerrit.ovirt.org/1247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ef5fb239be47714e0cebf4ce5c0ebf790384b79
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Split getSessionInfo() out of getdeviScsiInfo()
......................................................................
Split getSessionInfo() out of getdeviScsiInfo()
The original call is doing both things and a function should only do 1.
This patch also makes the result a namedtuple instead of a regular tuple
that is easier to handle programatically and converts all values to the
appropriate types.
Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451
---
M vdsm/storage/iscsi.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
3 files changed, 63 insertions(+), 29 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/1096/1
--
To view, visit http://gerrit.ovirt.org/1096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ba715a592f7d46e9d37c53d0abe1ea0c6fe4451
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Don't resolve hostnames for iscsi connection.
......................................................................
Don't resolve hostnames for iscsi connection.
The new storage provider connection subsystem can handle using hostnames
even though iscsid will resolve the hostname and report it as IP.
We should let the underlying layers handle it. Even though it will make
multiplathing act weird we shouldn't resolve the hostname ourselves as
it might interfere with some HA\Load balancing solution.
Change-Id: Ia13666d8f5dff01c2114df8195fcfb2369cc6eb2
---
M vdsm/storage/iscsi.py
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/1099/1
--
To view, visit http://gerrit.ovirt.org/1099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia13666d8f5dff01c2114df8195fcfb2369cc6eb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Serialize iscsiadm calls
......................................................................
Serialize iscsiadm calls
iscsiadm doesn't really support multiple call espescially to the same
resource. This will serialize all the calls to iscsiadm and prevent
issuse from multiple iscsi connections being issued at once.
Change-Id: I751abfd0c2ba20310d63dd569132e723ed06f687
---
M vdsm/storage/iscsi.py
1 file changed, 24 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/1249/1
--
To view, visit http://gerrit.ovirt.org/1249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I751abfd0c2ba20310d63dd569132e723ed06f687
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Persist active storage provider connections
......................................................................
Persist active storage provider connections
In order for VDSM to gracefully handle restarts it should make sure all
connections it was asked to manage before the crash are continued to be
managed when it goes up.
Note that there is no reconnection logic yet.
Change-Id: I91f29671e87e76765bc86907fb2d03318861d045
---
M vdsm/storage/hsm.py
M vdsm/storage/storageProviderConnectionMonitor.py
2 files changed, 59 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/1116/1
--
To view, visit http://gerrit.ovirt.org/1116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91f29671e87e76765bc86907fb2d03318861d045
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: contrib: Adding contrib/nfs-check.py
......................................................................
contrib: Adding contrib/nfs-check.py
nfs-check is a python script to validate nfs targets.
Currently, nfs-check mount the nfs target, create a file and read it from
the mountpoint. If somethings goes wrong it will throw the error message.
Usage: nfs-check.py [OPTIONS]
--server NFS server (REQUIRED)
--target NFS target (REQUIRED)
--local Local mountpoint (REQUIRED)
--opts NFS options (OPTIONAL)
--version List version release
--help This help menu
Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3
Example:
1) nfs-check.py --server 192.168.1.103 --target /nfs/storage --local /mnt
2) nfs-check.py --server 192.168.1.103 --target /nfs/storage --local /mnt --opts soft
---
A contrib/nfs-check.py
1 file changed, 157 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/916/1
--
To view, visit http://gerrit.ovirt.org/916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#773371 call `vdsmd reconfigure` after bootstrap
......................................................................
BZ#773371 call `vdsmd reconfigure` after bootstrap
If installation change ssl from False to True and added valid
certificates, we need to reconfigure vdsm to use it.
This was done by the "reconfigure" verb for our SysV daemon, but
unsupported by systemd.
This patch is an ugly hack for an oVirt release, until we have a proper
vdsm-tool for these purposes.
Change-Id: Ide0b9c1fb86c8d7bcea54d1ba8c8d9a7598af733
---
M vdsm_reg/deployUtil.py.in
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/1360/1
--
To view, visit http://gerrit.ovirt.org/1360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide0b9c1fb86c8d7bcea54d1ba8c8d9a7598af733
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLED
......................................................................
BZ#785557 bootstrap: do not mark mgmt bridge as NM_CONTROLLED
Network devices created by Vdsm should ask to be controlled by
NetworkManager. Particularly when NM does not support controlling them
(bridge device).
Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
---
M vdsm_reg/deployUtil.py.in
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/1370/1
--
To view, visit http://gerrit.ovirt.org/1370
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21c17d88d33b7cd2395a160a27f30569bc3c869c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add hotPlug/hotUnplug NIC feature
......................................................................
Add hotPlug/hotUnplug NIC feature
Change-Id: Iecd56650308f5836913f513fffc179f39fc8f6cc
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/define.py
M vdsm/libvirtvm.py
4 files changed, 118 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/1388/1
--
To view, visit http://gerrit.ovirt.org/1388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecd56650308f5836913f513fffc179f39fc8f6cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Excluding some VM commands on migration
......................................................................
Excluding some VM commands on migration
Some operations are not permitted during a live migration:
* take a live snapshot
* hotplug/hotunplug a disk device
Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
---
M vdsm/define.py
M vdsm/libvirtvm.py
M vdsm/vm.py
3 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/1389/1
--
To view, visit http://gerrit.ovirt.org/1389
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01a4197cdaa746130152a5768e8a3bb0c8b9de2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Minor code refactoring during domXml parsing
......................................................................
Minor code refactoring during domXml parsing
Change-Id: Ia3fbf8beed2cce3317ff711b39c24ddf6bffaab9
---
M vdsm/libvirtvm.py
1 file changed, 3 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/1365/1
--
To view, visit http://gerrit.ovirt.org/1365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3fbf8beed2cce3317ff711b39c24ddf6bffaab9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Replace SPM domain locks with SANLock
......................................................................
Replace SPM domain locks with SANLock
Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
---
M configure.ac
M vdsm.spec.in
M vdsm/constants.py.in.in
M vdsm/storage/blockSD.py
M vdsm/storage/safelease.py
M vdsm/storage/sd.py
M vdsm/storage/sp.py
M vdsm/storage/storage_exception.py
M vdsm/vdsmd.init.in
9 files changed, 167 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/726/1
--
To view, visit http://gerrit.ovirt.org/726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configure: replace AC_PATH_PROG to AC_CHECK_PROG
......................................................................
configure: replace AC_PATH_PROG to AC_CHECK_PROG
This patch replace the macro AC_PATH_PROG to AC_CHECK_PROG.
Currently, the AC_PATH_PROG doesn't check if the program really exists, for example:
$ nice
bash: nice: command not found...
If you run:
$ ./autogen.sh --system
<snip>
checking for nice... /bin/nice
</snip>
This is because the AC_PATH_PROG parameters are:
AC_PATH_PROG(variable, prog-to-check-for, [value-if-not-found], [path = ‘$PATH’])
^^ here
Our macro is;
AC_PATH_PROG([NICE_PATH], [nice], [/bin/nice])
The second point, if you are compiling your own packages and your
programs are located in a different directory AC_PATH_PROG will find it and
return the full path and break the rpm, example:
$ mkdir -p /usr/local/qemu/bin
$ mv /usr/bin/qemu-img /usr/local/qemu/bin/
$ export PATH=$PATH:/usr/local/qemu/bin
(including the new directory into the path)
$ ./autogen.sh --system
<snip>
checking for qemu-img...
/usr/local/qemu/bin/qemu-img
<snip>
Then, vdsm/constants.py will assume:
EXT_QEMUIMG = '/usr/local/qemu/bin/qemu-img' instead of /usr/bin/qemu-img
AC_CHECK_PROG can resolv that because if it find the program into the path,
we can provide the correct path.
AC_CHECK_PROG (variable, prog-to-check-for, value-if-found, [value-if-not-found], [path = ‘$PATH’], [reject])
Change-Id: I13b870c3e656dba2d840a341a5d6789a11036e40
---
M configure.ac
1 file changed, 266 insertions(+), 56 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/1114/1
--
To view, visit http://gerrit.ovirt.org/1114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13b870c3e656dba2d840a341a5d6789a11036e40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add hotPlug/hotUnplug NIC feature
......................................................................
Add hotPlug/hotUnplug NIC feature
Change-Id: I0c3885296d76f2cb3d6e80bc6f155832cb00e2a8
---
M vdsm/clientIF.py
M vdsm/define.py
M vdsm/libvirtvm.py
3 files changed, 109 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/1366/1
--
To view, visit http://gerrit.ovirt.org/1366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c3885296d76f2cb3d6e80bc6f155832cb00e2a8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Use self.log instead of log
......................................................................
Use self.log instead of log
Change-Id: I63005044d33f57b9533572ac2a9df8f05fe9d4f9
---
M vdsm/clientIF.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/1373/1
--
To view, visit http://gerrit.ovirt.org/1373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63005044d33f57b9533572ac2a9df8f05fe9d4f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: Move API out of clientIF
......................................................................
Move API out of clientIF
Many API functions are implemented inside clientIF but this is no longer the
proper place for them. Move API-related functions into their proper objects
inside API.py. clientIF still owns the storage dispatcher and the vm list. In
the future, I would like to move these out of clientIF as well but I have
decided to reserve that for a future patch series.
Change-Id: I94ad036cfaf3d1bec2f5b4049979a1bf0e2810ce
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/API.py
M vdsm/bindingXMLRPC.py
M vdsm/clientIF.py
3 files changed, 1,347 insertions(+), 897 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/985/1
--
To view, visit http://gerrit.ovirt.org/985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94ad036cfaf3d1bec2f5b4049979a1bf0e2810ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: Add an object model to clientIF
......................................................................
Add an object model to clientIF
Create an object-based API for vdsm. The current objects are: Task,
StoragePool, StorageDomain, Image, Volume, ISCSIConnection, LVMVolumeGroup, and
VM. Additionally, a Global object currently handles APIs which don't map nicely
to one of the above objects. Right now this interface is only an abstraction
that maps directly to the flat function namespace. This will change later in
the patch series and more over time. Since this API is internal (it only
affects bindings), we can continue to change it over time without affecting
ovirt-engine.
Change-Id: I2ee54277c87a02ac8dafe29a8761e2acf0f7397f
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm.spec.in
A vdsm/API.py
M vdsm/Makefile.am
3 files changed, 480 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/984/1
--
To view, visit http://gerrit.ovirt.org/984
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ee54277c87a02ac8dafe29a8761e2acf0f7397f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: Factor out xmlrpc server
......................................................................
Factor out xmlrpc server
Move the xmlrpc server code out of clientIF and into its own file.
Change-Id: I0372cf3a58324ec2e8daeeab3eca3167d2da7ccd
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/bindingXMLRPC.py
M vdsm/clientIF.py
4 files changed, 224 insertions(+), 210 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/983/1
--
To view, visit http://gerrit.ovirt.org/983
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0372cf3a58324ec2e8daeeab3eca3167d2da7ccd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: clientIF: Move wrapApiMethod into bindingXMLRPC class
......................................................................
clientIF: Move wrapApiMethod into bindingXMLRPC class
wrapApiMethod is now only used by bindingXMLRPC so make it a class member
instead of a global function.
Change-Id: Icfd8da9a0e072da192f4c3f86c05d0fa1c305f48
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/clientIF.py
1 file changed, 33 insertions(+), 33 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/621/1
--
To view, visit http://gerrit.ovirt.org/621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfd8da9a0e072da192f4c3f86c05d0fa1c305f48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Don't go through lvm for volume size if lv is active
......................................................................
Don't go through lvm for volume size if lv is active
Change-Id: I5e81bf563f07119a775888d6abc3c81f4f7b86a0
---
M vdsm/storage/blockVolume.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/677/1
--
To view, visit http://gerrit.ovirt.org/677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e81bf563f07119a775888d6abc3c81f4f7b86a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Adam Litke has uploaded a new change for review.
Change subject: API: Separate clientIF and the xmlrpc server
......................................................................
API: Separate clientIF and the xmlrpc server
Currently the xmlrpc server functionality is entwined with the clientIF class.
In order to proceed with the API bridge plan (http://ovirt.org/wiki/Vdsm_API) I
would like to separate the xmlrpc server into its own class. This brings
clientIF one step closer to becoming a generic API Bridge that is able to host
additional bindings such as REST and QMF.
Despite the size of this patch, this was a pretty simple refactoring. I made
the following choices as I split this out:
- The xmlrpc server binding class has start() and prepareForShutdown() APIs
- clientIF will still own the storage dispatcher but API wrapper mechanisms
have moved into the xmlrpc class.
Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
---
M vdsm/clientIF.py
1 file changed, 137 insertions(+), 110 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/620/1
--
To view, visit http://gerrit.ovirt.org/620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Add the live snapshot command to vdsClient
......................................................................
Add the live snapshot command to vdsClient
Add the new vdsClient command to take live snapshots:
vdsClient [-s] <host> snapshot \
<vmId> <vmDisk> <sdUUID> <spUUID> <imgUUID> <volUUID>
Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
---
M vdsm_cli/vdsClient.py
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/515/1
--
To view, visit http://gerrit.ovirt.org/515
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20a6811ea8c7908969eb69d721b39c479f304d08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: iscsi.py: fixed discovery issue and added support for iSER transport
......................................................................
iscsi.py: fixed discovery issue and added support for iSER transport
Fixed discovery of targets not to overwrite settings of already
connected targets.
Added support for iSER transport.
Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a
---
M vdsm/storage/iscsi.py
1 file changed, 39 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/905/1
--
To view, visit http://gerrit.ovirt.org/905
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1012219f5202882db62743e5f2cf5cbcaaca930a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: destroy may be called when the Vm is already Down
......................................................................
destroy may be called when the Vm is already Down
This patch fixes an error introduced in c0766ddb0852fd391d15424ae24761.
Change-Id: I50e4ca55262e64b13081cc832fba932e56aafd49
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/1321/1
--
To view, visit http://gerrit.ovirt.org/1321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50e4ca55262e64b13081cc832fba932e56aafd49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: [WIP] add a serial console to each Vm
......................................................................
[WIP] add a serial console to each Vm
We would like to support `virsh console`.
Should we prefer to virtio-console over serial one?
Change-Id: Id4e14963a5bc220f1fcc33477f19ef2eed1428ba
---
M vdsm/libvirtvm.py
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/585/1
--
To view, visit http://gerrit.ovirt.org/585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4e14963a5bc220f1fcc33477f19ef2eed1428ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: [WIP] add before_vm_destroy hook
......................................................................
[WIP] add before_vm_destroy hook
Run a hook directory when a Vm is asked to die. Note that a Vm may die
without being asked to, were the hook would not run.
This hook is currently missing from Vdsm since I was not sure what
should be its exact semantic. However in hindsight, we'd better have
something (even awkward) and improve after feedback from the real world.
Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
---
M vdsm.spec.in
M vdsm/hooks.py
M vdsm/libvirtvm.py
M vdsm/vdsmd.8.in
4 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/1175/1
--
To view, visit http://gerrit.ovirt.org/1175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide2c143921e58944df97c3dc74cd20cd85b1dae8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add hotPlug/hotUnplug disk feature
......................................................................
Add hotPlug/hotUnplug disk feature
Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221
---
M vdsm/clientIF.py
M vdsm/define.py
M vdsm/libvirtvm.py
M vdsm/vm.py
4 files changed, 105 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/1108/1
--
To view, visit http://gerrit.ovirt.org/1108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecab9e28b2e77cfeedc3b9068095f7d117eb6221
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Matthias Heinz has uploaded a new change for review.
Change subject: This patch adds some basic debian support
......................................................................
This patch adds some basic debian support
Change-Id: Ie021cd9f64f80fde2442b6ad7c75c0b5b1c746ff
---
M vdsm/caps.py
M vdsm/clientIF.py
2 files changed, 46 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/1110/1
--
To view, visit http://gerrit.ovirt.org/1110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie021cd9f64f80fde2442b6ad7c75c0b5b1c746ff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Matthias Heinz <matthias.heinz(a)goobernetworks.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vds_bootstrap: search if vdsm is already installed
......................................................................
vds_bootstrap: search if vdsm is already installed
If vdsm is already installed into the machine, let's locate it using
"rpm -q (getPackageInfo())" instead of use yumSearch() or yumSearchVersion().
The current behaviour: if yum cannot find vdsm into the repo (even if
vdsm is already installed into the system) the node installation will fail.
With this patch, if the system already has vdsm, it will continue the
installation and will jump the yum functions for vdsm.
Change-Id: I82beb5599225cfd3aa98ac7aa23b7152493421a9
---
M vds_bootstrap/vds_bootstrap.py
1 file changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/1240/1
--
To view, visit http://gerrit.ovirt.org/1240
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82beb5599225cfd3aa98ac7aa23b7152493421a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Haim Ateya has uploaded a new change for review.
Change subject: Set exc_info=True when self.message is used in log.error for vds_bootstrap
......................................................................
Set exc_info=True when self.message is used in log.error for
vds_bootstrap
Change-Id: Id5fa63d9809e5f7130e304eceede6d41a27a12a6
---
M vds_bootstrap/vds_bootstrap.py
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/945/1
--
To view, visit http://gerrit.ovirt.org/945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5fa63d9809e5f7130e304eceede6d41a27a12a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: BZ#619360 enable and start ntpd
......................................................................
BZ#619360 enable and start ntpd
Vdsm needs to keep host time in sync, or else guest time would lap if
guest is started on a different host. Make sure ntpd is running.
Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
---
M vds_bootstrap/vds_bootstrap.py
M vdsm/vdsmd.init.in
M vdsm/vdsmd.service
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/903/1
--
To view, visit http://gerrit.ovirt.org/903
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1504a5d86e71ae2d210ada6a89e9c55b46f99d14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add validate minimal keys set in dictionaries
......................................................................
Add validate minimal keys set in dictionaries
Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
---
M vdsm/utils.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/540/1
--
To view, visit http://gerrit.ovirt.org/540
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66b9d3947b676e7ed361bab1d552dfbcb4f6e342
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
mhuntxu(a)gmail.com has uploaded a new change for review.
Change subject: Make getRoutes() return the default gateway of an interface, otherwise the gateway of an interface last occurs in /proc/net/route would be the result when multiple gateways are assigned to the interface, which is clearly not we want.
......................................................................
Make getRoutes() return the default gateway of an interface,
otherwise the gateway of an interface last occurs in /proc/net/route
would be the result when multiple gateways are assigned to the
interface, which is clearly not we want.
Change-Id: I6bceb3be2495bc80931c709e2132ff4542e6b763
---
M vdsm/netinfo.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/1101/1
--
To view, visit http://gerrit.ovirt.org/1101
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bceb3be2495bc80931c709e2132ff4542e6b763
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mhuntxu(a)gmail.com
Dan Kenigsberg has uploaded a new change for review.
Change subject: setupNetwork: release deleted network first
......................................................................
setupNetwork: release deleted network first
We may need their resources for newly requested networks.
Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
---
M vdsm/configNetwork.py
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/893/1
--
To view, visit http://gerrit.ovirt.org/893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23f5feb0005fd6853793979dbfba84f89dd9c5fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Fix race during VM recovery flow
......................................................................
Fix race during VM recovery flow
In this patch:
* Save conf just after build devices
* Add identifier ID and __eq__ to Drive and NIC devices.
Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
---
M vdsm/libvirtvm.py
1 file changed, 30 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/1174/1
--
To view, visit http://gerrit.ovirt.org/1174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92064e8ae3f1415d22ed8142d56fc0dc14ffbe48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Do not distribute vdsm-gencert.sh
......................................................................
Do not distribute vdsm-gencert.sh
... and particularly not one that has /usr/local as a prefix, and fails rpm
creation.
Change-Id: I3958c746d15698a9dea5d92423cb00a3cc07c0e1
---
M vdsm/Makefile.am
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/1201/1
--
To view, visit http://gerrit.ovirt.org/1201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3958c746d15698a9dea5d92423cb00a3cc07c0e1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Fix race during VM recovery flow
......................................................................
Fix race during VM recovery flow
In this patch:
* Save conf just after build devices
Change-Id: I9253423d0f6ff849022dabf8e29409a1a5e59851
---
M vdsm/libvirtvm.py
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/1183/1
--
To view, visit http://gerrit.ovirt.org/1183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9253423d0f6ff849022dabf8e29409a1a5e59851
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Mark Wu has uploaded a new change for review.
Change subject: Ignore differences in case when comparing mac addresses
......................................................................
Ignore differences in case when comparing mac addresses
Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
---
M vdsm/libvirtvm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/1059/1
--
To view, visit http://gerrit.ovirt.org/1059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id59b2228f83aa2506da1f4a1011469e63dfc1e9c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Avoid to activate parent volume on cloning
......................................................................
Avoid to activate parent volume on cloning
The benefit is that we can now create new snapshot volumes without
looking at the parent. This is indispensable for live snapshots since
the parent volume is in use by the VM.
In this patch:
* Do not activate the parent volume on cloning (it could be in use
by the VM), the only information needed is the size and it can be
provided as additional parameter in qemu-img
* Do not change the volume permission to read-only when setting the
parent to "internal" (it could be in use by the VM)
Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3
---
M vdsm/storage/volume.py
1 file changed, 11 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/570/1
--
To view, visit http://gerrit.ovirt.org/570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Refactor prepareVolumePath in clientIF
......................................................................
Refactor prepareVolumePath in clientIF
In this patch:
* refactoring
* set drive['volumeChain'] (required for sanlock and bz760547)
* set drive['blockDev'] (required for the hotplug feature)
Change-Id: I08f86b32a71d61ade123ceea541c51b669d84ca0
---
M vdsm/clientIF.py
M vdsm/vm.py
2 files changed, 28 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/1141/1
--
To view, visit http://gerrit.ovirt.org/1141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08f86b32a71d61ade123ceea541c51b669d84ca0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Remove the _preparedDrives dictionary from vm
......................................................................
Remove the _preparedDrives dictionary from vm
The _preparedDrives dictionary was a fix for bz670599 introduced with
the commit 7aa57fe. Currently prepareVolumePath is not relying on the
resource manager anymore and therefore the race fix is superfluous.
In this patch:
* remove the _preparedDrives dictionary and its lock (_volPrepareLock)
* make prepareVolumePath and teardownVolumePath public
Change-Id: I8d310f216987b7ded89e71752464934f70c051ad
---
M vdsm/clientIF.py
M vdsm/libvirtvm.py
M vdsm/vm.py
3 files changed, 26 insertions(+), 47 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/1123/1
--
To view, visit http://gerrit.ovirt.org/1123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d310f216987b7ded89e71752464934f70c051ad
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Do not lock the image when preparing the VM path
......................................................................
Do not lock the image when preparing the VM path
Since the resource manager scope is local there is no need for a VM
to take an exclusive lock on the images: in fact the SPM running on
an other machine could still manipulate such images.
Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
---
M vdsm/clientIF.py
M vdsm/storage/hsm.py
2 files changed, 14 insertions(+), 114 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/554/1
--
To view, visit http://gerrit.ovirt.org/554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b5cb55a868cb9bf5a720610273af139ee858a1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm_cli/Makefile: Add link to SecureXMLRPCServer
......................................................................
vdsm_cli/Makefile: Add link to SecureXMLRPCServer
vdsClient cannot be executed inside the vdsm_cli directory without
a link to SecureXMLRPCServer. This might help to debug/trace approaches.
Example:
$ python ./vdsClient.py -m trace --listfuncs vdsClient.py -s 192.168.1.203 getVdsCaps
Traceback (most recent call last):
File "vdsClient.py", line 28, in <module>
import vdscli
File "/home/vdsmdevel/erro-break-vdsClient/vdsm/vdsm_cli/vdscli.py",
line 25, in <module>
ImportError: No module named SecureXMLRPCServer
$ python ./vdsClient.py
Traceback (most recent call last):
File "./vdsClient.py", line 28, in <module>
import vdscli
File "/home/vdsmdevel/erro-break-vdsClient/vdsm/vdsm_cli/vdscli.py",
line 25, in <module>
import SecureXMLRPCServer
ImportError: No module named SecureXMLRPCServer
Change-Id: Ic4b6ca04e2048e6cc7381850c186e84bb3f41f6e
---
M vdsm_cli/Makefile.am
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/1142/1
--
To view, visit http://gerrit.ovirt.org/1142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4b6ca04e2048e6cc7381850c186e84bb3f41f6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Eduardo has uploaded a new change for review.
Change subject: BZ#783098 - notFound should be and iterable and not an iterator.
......................................................................
BZ#783098 - notFound should be and iterable and not an iterator.
Change-Id: If4074c6e87cff734bbae95074f5d2e4bc6ff8374
---
M vdsm/storage/lvm.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/1139/1
--
To view, visit http://gerrit.ovirt.org/1139
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4074c6e87cff734bbae95074f5d2e4bc6ff8374
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: getDevInfo: report partioned devices, too
......................................................................
getDevInfo: report partioned devices, too
One cannot create a PV on a partitioned device, and therefor such
devices where not reported to Engine. This proved surprising to users
who woder where their LUN disappeared.
Vdsm should report all devices, and ovirt-engine should mark partitioned
devices as unworthy of a PV. In the future, Vdsm may allow to forcefully
remove a partition table from a device, to make it usable as a PV.
Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
---
M vdsm/storage/hsm.py
1 file changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/944/1
--
To view, visit http://gerrit.ovirt.org/944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5eddfcb587aec5337adaef810bf11665a7dffde
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: hard-coding the value of se.StorageException.code is ugly
......................................................................
hard-coding the value of se.StorageException.code is ugly
Change-Id: Icc7ea7427d3834344a89671caa526b7812a5eb2a
---
M vdsm/storage/sp.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/922/1
--
To view, visit http://gerrit.ovirt.org/922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc7ea7427d3834344a89671caa526b7812a5eb2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Igor Lvovsky has abandoned this change.
Change subject: Return domXml and its md5 per VM.
......................................................................
Patch Set 3: Abandoned
--
To view, visit http://gerrit.usersys.redhat.com/1035
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5b3a97fa998d0f52ebe752024c62b8ec16c32c78
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has abandoned this change.
Change subject: Add support for new 'domxml' parameter to create VM API.
......................................................................
Patch Set 1: Abandoned
--
To view, visit http://gerrit.usersys.redhat.com/1084
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1ba723122273ace3faeced1ea9580b510f84d92c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Group the cluster lock code into a new SP method
......................................................................
Group the cluster lock code into a new SP method
Both the create and reconstructMaster methods were sharing a very
similar code for temporarly acquiring the cluster lock.
Change-Id: I981d84af7816ccd2db64eb5beb440e9f7637f734
---
M vdsm/storage/sp.py
1 file changed, 29 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/603/1
--
To view, visit http://gerrit.ovirt.org/603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I981d84af7816ccd2db64eb5beb440e9f7637f734
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Support stable PCI address for uknown general devices
......................................................................
Support stable PCI address for uknown general devices
Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 117 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/1040/1
--
To view, visit http://gerrit.ovirt.org/1040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I664fc7326673ac0dcba487ed906c3daf652f8956
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Support stable PCI address for controller devices
......................................................................
Support stable PCI address for controller devices
Change-Id: If69b39fd4d801043763160efbccafdc49b5eabf0
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 68 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/1039/1
--
To view, visit http://gerrit.ovirt.org/1039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If69b39fd4d801043763160efbccafdc49b5eabf0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Juan Hernandez has uploaded a new change for review.
Change subject: Handle correctly nic names like p33p1.
......................................................................
Handle correctly nic names like p33p1.
Currently these types of network interface names are not handled
correctly in the "nicSort" method because it assumes that the name
is composed by a name (like "eth") and a number. As a result
anything after the first number is removed.
Change-Id: I716f5d7d137325abaa0022a40f482c9ad270855a
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/799/1
--
To view, visit http://gerrit.ovirt.org/799
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I716f5d7d137325abaa0022a40f482c9ad270855a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Move all the substitution at make time
......................................................................
Move all the substitution at make time
Moving all the substitution at make time will avoid the
Change-Id: I1f6956350971a88294559039e4ff00fce2637c78
---
M .gitignore
M Makefile.am
M build-aux/Makefile.subs
M configure.ac
M vdsm/Makefile.am
R vdsm/constants.py.in
M vdsm/sos/Makefile.am
R vdsm/sudoers.vdsm.in
M vdsm_cli/Makefile.am
M vdsm_hooks/Makefile.am
M vdsm_hooks/faqemu/Makefile.am
M vdsm_reg/Makefile.am
12 files changed, 60 insertions(+), 30 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/1034/1
--
To view, visit http://gerrit.ovirt.org/1034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f6956350971a88294559039e4ff00fce2637c78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Return domXml and its md5 per VM.
......................................................................
Return domXml and its md5 per VM.
Report full domXml per VM by using the 'list' verb with the option full = true.
The 'getVmStats'/'getAllVmStats' verbs report the md5 of the domXml per VM.
Change-Id: I5b3a97fa998d0f52ebe752024c62b8ec16c32c78
---
M vdsm/libvirtvm.py
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/235/1
--
To view, visit http://gerrit.ovirt.org/235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b3a97fa998d0f52ebe752024c62b8ec16c32c78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add 'readonly' attribute to disk's libvirt XML
......................................................................
Add 'readonly' attribute to disk's libvirt XML
Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/1049/1
--
To view, visit http://gerrit.ovirt.org/1049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I200cd36c7e36452019d9022789d2d3fb4303c4e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Use drive[path] only after it is known
......................................................................
Use drive[path] only after it is known
Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/1066/1
--
To view, visit http://gerrit.ovirt.org/1066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c43c0b0bc25c42c2aac4dd2e99f7931d46fabe0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Lee Yarwood has uploaded a new change for review.
Change subject: Improves logging when attempting to run hooks for a vm.
......................................................................
Improves logging when attempting to run hooks for a vm.
Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4
---
M vdsm/hooks.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/243/1
--
To view, visit http://gerrit.ovirt.org/243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: bz773364 cancel-migration: abort migration on dest results an exception
......................................................................
bz773364 cancel-migration: abort migration on dest results an exception
while starting migration, it appear in dest host vm list.
when trying to cancel migration the _dom have not set, and when trying
to call abortJob() we get AttributeError() exception.
Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/1041/1
--
To view, visit http://gerrit.ovirt.org/1041
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11d64e79f1a0cebde7a392af0d729ae0f192a844
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Mark vds_bootstrap as executable in the Makefile
......................................................................
Mark vds_bootstrap as executable in the Makefile
The bootstrap files should be always installed as executables (not only
in the rpm package).
Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19
---
M vds_bootstrap/Makefile.am
M vdsm.spec.in
M vdsm_reg/Makefile.am
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/966/1
--
To view, visit http://gerrit.ovirt.org/966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Move limit configuration to it's proper place
......................................................................
Move limit configuration to it's proper place
currently limit configuration is managed part by vdsmd.init and part by
vdsm configuration. This is confusing an non standard. Putting a vdsm
configuration file in limits.d will make admins life easier when looking
to change VDSM's limits.
Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/config.py.in
A vdsm/limits.conf
M vdsm/vdsmd.init.in
5 files changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/914/1
--
To view, visit http://gerrit.ovirt.org/914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26345e634e59512c47ce5a52179d65951787c5c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Throw key error in case on missing or already registered namespace
......................................................................
Throw key error in case on missing or already registered namespace
Change-Id: Ibb7fdaa87ea4db1d1d080ecccde43d248117f4d2
---
M vdsm/storage/resourceManager.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/915/1
--
To view, visit http://gerrit.ovirt.org/915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb7fdaa87ea4db1d1d080ecccde43d248117f4d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: allow running old-style Vm without 'drives'
......................................................................
allow running old-style Vm without 'drives'
This has no effect on engine-initiated VMs which always have 'drives'
(or in the future, 'devices'). Only manual tests are affected.
Change-Id: I9f64ddfbf2596724bec624af161507bad98c2e63
---
M vdsm/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/1058/1
--
To view, visit http://gerrit.ovirt.org/1058
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f64ddfbf2596724bec624af161507bad98c2e63
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: drop ugly dead function execAndGetOutput
......................................................................
drop ugly dead function execAndGetOutput
Change-Id: Ice3082a0223f02bc513c7f15184bc922c00dba47
---
M vdsm/utils.py
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/1050/1
--
To view, visit http://gerrit.ovirt.org/1050
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice3082a0223f02bc513c7f15184bc922c00dba47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Use a copy of the domainsToUpgrade
......................................................................
Use a copy of the domainsToUpgrade
The original code just uses another ref that is changed while iterated
which has unexpected results. This was not apparent as the remove might
happened after the iteration because it might run in another thread.
To illustrate:
In [1]: a = [1,2,3,4,5,6,7,8,9,10]
In [2]: for i in a:
...: a.remove(i)
...:
In [3]: a
Out[3]: [2, 4, 6, 8, 10]
In [4]: for i in a:
...: a.remove(i)
...:
In [5]: a
Out[5]: [4, 8]
In [6]: for i in a[:]:
...: a.remove(i)
...:
In [7]: a
Out[7]: []
Fun!
Change-Id: I3de0646af2fe9a9fcde708837cfcd83d10385026
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/900/1
--
To view, visit http://gerrit.ovirt.org/900
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3de0646af2fe9a9fcde708837cfcd83d10385026
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Eduardo has uploaded a new change for review.
Change subject: Fix HSM flows should not change rw permissions.
......................................................................
Fix HSM flows should not change rw permissions.
This whole setrw flow should not be done in HSM flows, as prepare
volume is.
In blocks domains can change VG metadata!
Minimal fix needs further development.
Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
---
M vdsm/storage/volume.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/797/1
--
To view, visit http://gerrit.ovirt.org/797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia53f0008cf3e7b25e14c7f03798c1ae527056725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: bz772670: [rhevh] network is not set after using boot params
......................................................................
bz772670: [rhevh] network is not set after using boot params
when using vdsm-reg we are adding/deleting network before libvirt start.
added a hidden parameter to add/delNetwork if we want to call libvirt
add-network.
when vdsm is up its syncing the libvirt network with host bridge.
Change-Id: I87e425c684a187e5dd874d11646aa7acf676e0a2
---
M vdsm/configNetwork.py
M vdsm_reg/deployUtil.py.in
2 files changed, 14 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/1024/1
--
To view, visit http://gerrit.ovirt.org/1024
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87e425c684a187e5dd874d11646aa7acf676e0a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Set default drive reqsize and apparentsize to '0'
......................................................................
Set default drive reqsize and apparentsize to '0'
In some situations (eg: empty cdrom drive) the 'reqsize' and
'apparentsize' arguments are missing and they should be considered '0'.
Change-Id: Iba8168a40c9b2d27c60788f5f97d3f7551df2781
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/990/1
--
To view, visit http://gerrit.ovirt.org/990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba8168a40c9b2d27c60788f5f97d3f7551df2781
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Dan Kenigsberg has uploaded a new change for review.
Change subject: Specify which user/group should be used for core dumps rotation
......................................................................
Specify which user/group should be used for core dumps rotation
New 'su' directive is new to logrotate 3.8.0. This patch breaks systems
with older logrotate.
Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643
---
M configure.ac
M vdsm.spec.in
R vdsm/vdsm-logrotate.conf.in
3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/971/1
--
To view, visit http://gerrit.ovirt.org/971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38738f494e9bd241ea27e6e18b4d348fc3dfe643
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: mhuntxu(a)gmail.com
Igor Lvovsky has uploaded a new change for review.
Change subject: Add support for new 'domxml' parameter to create VM API.
......................................................................
Add support for new 'domxml' parameter to create VM API.
Add new 'domxml':<blob XML> key:value to vmParams dictionary.
Parse <blob XML> to figure out devices addresses and build proper XML for libvirt.
Change-Id: I1ba723122273ace3faeced1ea9580b510f84d92c
---
M vdsm/clientIF.py
M vdsm/libvirtvm.py
2 files changed, 71 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/236/1
--
To view, visit http://gerrit.ovirt.org/236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ba723122273ace3faeced1ea9580b510f84d92c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Support specParams parameter as dictionary per device
......................................................................
Support specParams parameter as dictionary per device
Change-Id: I0e584931d77c2f64ee5a1d613d6b73e6d0397ba7
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/979/1
--
To view, visit http://gerrit.ovirt.org/979
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e584931d77c2f64ee5a1d613d6b73e6d0397ba7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: All size parameters in vm's conf should be strings and not integers
......................................................................
All size parameters in vm's conf should be strings and not integers
Change-Id: Ief705e67908ee5a2dbe6a51959e47789d78aaa16
---
M vdsm/vm.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/978/1
--
To view, visit http://gerrit.ovirt.org/978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief705e67908ee5a2dbe6a51959e47789d78aaa16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Don't change the name of a secured class
......................................................................
Don't change the name of a secured class
The variable 'name' used to name the secured classes was overridden
by the 'name' variable used to cycle over the methods.
The result was that the secured classes were renamed to their last
method name, eg: storage.sp.StoragePool => storage.sp.setMaxHostId.
Change-Id: I7d34b14391a0940e1ca73b8d736877f49b1c47f5
---
M vdsm/storage/securable.py
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/974/1
--
To view, visit http://gerrit.ovirt.org/974
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d34b14391a0940e1ca73b8d736877f49b1c47f5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Igor Lvovsky has posted comments on this change.
Change subject: Extracted image related functinality to another class
......................................................................
Patch Set 19: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 128: # I DON'T CARE. Will be handeled later.
I hope you will
--
To view, visit http://gerrit.ovirt.org/191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic29dc8d964f0c2e56329e7044a3b2f48a9f2e193
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: Extracted image related functinality to another class
......................................................................
Patch Set 19: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic29dc8d964f0c2e56329e7044a3b2f48a9f2e193
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Eduardo has uploaded a new change for review.
Change subject: Remove unnecesary validates.
......................................................................
Remove unnecesary validates.
All this instances race with the "recover" state of the VDSM,
if disk info is required when the StoragePool is not reconnected
yet.
Change-Id: I55482fc5ce78d68d5af7ba62c92d253e19f45e6b
---
M vdsm/storage/hsm.py
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/801/1
--
To view, visit http://gerrit.ovirt.org/801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55482fc5ce78d68d5af7ba62c92d253e19f45e6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Eduardo has uploaded a new change for review.
Change subject: Remove unnecessary validation.
......................................................................
Remove unnecessary validation.
This check prevents VDSM to query info about a disk on a running
VM after VDSM restart.
Change-Id: I3b9c89402f28614a893c9c4a1d8abbb55d9eaf1f
---
M vdsm/storage/hsm.py
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/800/1
--
To view, visit http://gerrit.ovirt.org/800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b9c89402f28614a893c9c4a1d8abbb55d9eaf1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: For BC we should to keep running VM run after vdsm upgrade.
......................................................................
For BC we should to keep running VM run after vdsm upgrade.
So, because this vm doesn't have normalize conf we need to build it
in recovery flow
Change-Id: I67d555b1b75e3287d083ccde6e1f0869f09f3234
---
M vdsm/libvirtvm.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/949/1
--
To view, visit http://gerrit.ovirt.org/949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67d555b1b75e3287d083ccde6e1f0869f09f3234
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Fix sendExtendMsg declaration, should be public
......................................................................
Fix sendExtendMsg declaration, should be public
Change-Id: Idc060de51daf573b462c2f4ade789fd884e627a6
---
M vdsm/storage/hsm.py
M vdsm/vm.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/948/1
--
To view, visit http://gerrit.ovirt.org/948
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc060de51daf573b462c2f4ade789fd884e627a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move domain monitor out of sp.py
......................................................................
Move domain monitor out of sp.py
Domain monitoring logic should be seperated from the core pool logic to
reduce StoragePool class complexity
Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
---
M vdsm.spec.in
M vdsm/storage/Makefile.am
A vdsm/storage/domainMonitor.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
5 files changed, 221 insertions(+), 187 deletions(-)
Approvals:
Saggi Mizrahi: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
Saggi Mizrahi has uploaded a new change for review.
Change subject: Make exprting more pythonic
......................................................................
Make exprting more pythonic
This seperated the dispatcher from hsm and allows us to add propertoes
to all public function with ease
Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
---
M vdsm/clientIF.py
M vdsm/storage/dispatcher.py
M vdsm/storage/hsm.py
M vdsm/vdsm
4 files changed, 185 insertions(+), 184 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/208/1
--
To view, visit http://gerrit.ovirt.org/208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e26da2a53bae5e897cebdb41af9abe519760aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Move reconnect file existence check
......................................................................
Move reconnect file existence check
Move the check to the inside of the _saveReconnectFunction show it's
always recreated.
Change-Id: I72abecc0dab58cd008d0afe8046d2b3c8f898517
---
M vdsm/storage/sp.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/917/1
--
To view, visit http://gerrit.ovirt.org/917
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72abecc0dab58cd008d0afe8046d2b3c8f898517
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
I don't like the paradigm, as it requires changing a property name in two places. but ok.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
Saggi Mizrahi has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
Because it will be used mostly for consumption outside the module I think it's a convenient way to know what fields return from domainMonitorStatus. Just trying this coding paradigm out seeing if I like it. It can't hurt and you can remove it at any time.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
Dan Kenigsberg has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 19: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/domainMonitor.py
Line 29: "vgMdFreeBelowThreashold")
I wouldn't have bothered with __slots__ - we do not plan for 1000s SDs for the size to matter.
Or is there a hidden cause for this?
....................................................
File vdsm/storage/hsm.py
Line 2580: # Stop repoStat threads
are you sure this code works?
I'd expect self.pools.values() here.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
Haim Ateya has uploaded a new change for review.
Change subject: BZ#674010 - Fix name error in vdsClient - 'commands' not found
......................................................................
BZ#674010 - Fix name error in vdsClient - 'commands' not found
Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
---
M vdsm_cli/vdsClient.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/906/1
--
To view, visit http://gerrit.ovirt.org/906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I091b32ff19d59ec7036ee440ee60913c06be4c13
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Normalize network parameter for VM create flow
......................................................................
Normalize network parameter for VM create flow
Add new LibvirtNetwork class to normalize network parameters
and create proper libvirt XML
Change-Id: I2d064dcdb639a5d98762a153d21de93f43c43254
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 131 insertions(+), 87 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/790/1
--
To view, visit http://gerrit.ovirt.org/790
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d064dcdb639a5d98762a153d21de93f43c43254
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Move VmStatsThread to use normalized network parameter
......................................................................
Move VmStatsThread to use normalized network parameter
Change-Id: I836539fcf7a21e07a818543228a25f9085c11c75
---
M vdsm/libvirtvm.py
1 file changed, 17 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/791/1
--
To view, visit http://gerrit.ovirt.org/791
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I836539fcf7a21e07a818543228a25f9085c11c75
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add general Device class
......................................................................
Add general Device class
Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 23 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/792/1
--
To view, visit http://gerrit.ovirt.org/792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie283db627644ad3b98e1d67fb97253426f536eb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Normalize sound parameter for VM create flow
......................................................................
Normalize sound parameter for VM create flow
Change-Id: I6b03430e183e17c113148da56c950ab80b3aed16
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 35 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/793/1
--
To view, visit http://gerrit.ovirt.org/793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b03430e183e17c113148da56c950ab80b3aed16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Normalize video parameter for VM create flow
......................................................................
Normalize video parameter for VM create flow
Change-Id: Iffae98832e9b031ffefec9f6d877afbfa6d61fa8
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 47 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/794/1
--
To view, visit http://gerrit.ovirt.org/794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iffae98832e9b031ffefec9f6d877afbfa6d61fa8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Add 'devices' key to the VM configuration.
......................................................................
Add 'devices' key to the VM configuration.
For old type vmParams, new 'devices' key will be created with all devices info.
Change-Id: Icf4aa449b713ecfa08b68e9ebe8c196f6d16a4e8
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 37 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/795/1
--
To view, visit http://gerrit.ovirt.org/795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf4aa449b713ecfa08b68e9ebe8c196f6d16a4e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Introducing support of new parameter for VM create
......................................................................
Introducing support of new parameter for VM create
Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 39 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/788/1
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: vdsm: new verb: migration cancel
......................................................................
vdsm: new verb: migration cancel
the verb migrateCancel will take vmid and try to stop migration,
if there is no migration in progress it will return error.
Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
---
M vdsm/clientIF.py
M vdsm/define.py
M vdsm/libvirtvm.py
M vdsm/vm.py
4 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/480/1
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Set the soft limit to be the hard limit so we scale as much as possible
......................................................................
Set the soft limit to be the hard limit so we scale as much as possible
Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
---
M vdsm/vdsm
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/674/1
--
To view, visit http://gerrit.ovirt.org/674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cdc48f9a2e61a5caa7e94f067f8182d4ecb3146
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm_reg: rename rhevm.py to engine.py
......................................................................
vdsm_reg: rename rhevm.py to engine.py
Renamed the file rhevm to engine.
BZ#771414
Change-Id: I2a49c22a3ebfcf31fd5653a1e7fdd88d53c8f7a5
---
M vdsm.spec.in
M vdsm_reg/Makefile.am
R vdsm_reg/engine.py
3 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/899/1
--
To view, visit http://gerrit.ovirt.org/899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a49c22a3ebfcf31fd5653a1e7fdd88d53c8f7a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Saggi Mizrahi has uploaded a new change for review.
Change subject: Removed useless docs from lvm.py. man pages exist for a reason
......................................................................
Removed useless docs from lvm.py. man pages exist for a reason
Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
---
M vdsm/storage/lvm.py
1 file changed, 0 insertions(+), 99 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/680/1
--
To view, visit http://gerrit.ovirt.org/680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70975ba7e7494a6d6e62acdfed8cd298f1f6f278
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 17: (2 inline comments)
I did not review this too closely, but I do not want to delay this. feel free to submit.
....................................................
File vdsm/storage/hsm.py
Line 2586: self.log.warning("Failed to stop RepoStats thread", exc_info=True)
comment out of date
....................................................
File vdsm/storage/sp.py
Line 1284: code = 200
se.GeneralException.code is so much catchier than 200
yeah, I now see it in the original. still git would blame this commit.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
Igor Lvovsky has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 17: Looks good to me, but someone else must approve
Please, open the ticket for pre-integration team
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
Igor Lvovsky has uploaded a new change for review.
Change subject: Fix floppy drives: bus should be 'fdc'.
......................................................................
Fix floppy drives: bus should be 'fdc'.
Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
---
M vdsm/vm.py
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/787/1
--
To view, visit http://gerrit.ovirt.org/787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I912cc1418e0df32d44bbc1a7c79c496aebd86c36
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Federico Simoncelli has uploaded a new change for review.
Change subject: Compile python files using automake
......................................................................
Compile python files using automake
In this patch:
* Use the PYTHON macro to compile python files
* Remove the redhat-rpm-config build dependency
* Move the vdsm sos plugin into its own directory to avoid the custom
file renaming and to use the PYTHON macro
* Update the gitignore file and the copyright in the touched files
* Add the all-local target to force the substitutions in the python
files
Change-Id: I7dce5c317605b84ec883feb04bfc83c5f64d921b
---
M .gitignore
M configure.ac
M vds_bootstrap/Makefile.am
M vdsm.spec.in
M vdsm/Makefile.am
A vdsm/sos/Makefile.am
R vdsm/sos/vdsm.py.in
M vdsm/storage/Makefile.am
M vdsm_cli/Makefile.am
M vdsm_reg/Makefile.am
10 files changed, 179 insertions(+), 58 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/708/1
--
To view, visit http://gerrit.ovirt.org/708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dce5c317605b84ec883feb04bfc83c5f64d921b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has posted comments on this change.
Change subject: Move domain monitor out of sp.py
......................................................................
Patch Set 16: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/domainMonitor.py
Line 44: # warning mechanizm.
mechanism
Line 126: try:
The try/except block should protect the onDomainConnectivityStateChange.emit part only.
Line 128: self.log.debug("Domain `%s` changed its status to %s", domain.sdUUID, {True:"valid", False:"Invalid"}[nextStatus.valid])
Spaces, case consistency and 80 columns. We might want the True/False dictionary as constant somewhere in the module/class.
--
To view, visit http://gerrit.ovirt.org/190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18f30541a3466c532b2fd6144cd54b46545aff0c
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ilvovsky(a)gmail.com
Roy Golan has uploaded a new change for review.
Change subject: vds_boostrap: rename rhevm to engine
......................................................................
vds_boostrap: rename rhevm to engine
Change-Id: Id1c98658af80ad52a14934a962be4945c91ff48d
---
M vds_bootstrap/vds_bootstrap.py
M vdsm_reg/config.py
M vdsm_reg/deployUtil.py.in
M vdsm_reg/vdsm-reg-setup
M vdsm_reg/vdsm-reg.conf.in
5 files changed, 28 insertions(+), 28 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/311/1
--
To view, visit http://gerrit.ovirt.org/311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1c98658af80ad52a14934a962be4945c91ff48d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Haim Ateya has uploaded a new change for review.
Change subject: BZ769179 - Omit getSessionList from vdsClient and its dependent files
......................................................................
BZ769179 - Omit getSessionList from vdsClient and its dependent files
Change-Id: Ia448f4e8c2720b5958fef59f4f55b2f4ae63d2ac
---
M vdsm/doc/source/storage/overview.rst
M vdsm/vdsm-sosplugin.py.in
M vdsm_cli/vdsClient.py
3 files changed, 1 insertion(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/659/1
--
To view, visit http://gerrit.ovirt.org/659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia448f4e8c2720b5958fef59f4f55b2f4ae63d2ac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>