On Wed, Oct 20, 2010 at 04:04:50PM +0200, Elad wrote:
2010/10/19 Paul Frields <stickster(a)gmail.com>:
> On Tue, Oct 19, 2010 at 4:08 AM, אלעד <el.il(a)doom.co.il> wrote:
>> 2010/10/19 shaiton <shaiton(a)fedoraproject.org>:
>>> On Tue, Oct 19, 2010 at 5:22 AM, Paul W. Frields <stickster(a)gmail.com>
wrote:
>>>> On Mon, Oct 18, 2010 at 04:23:15PM -0500, Sijis Aviles wrote:
>>>>> On Mon, Oct 18, 2010 at 3:29 PM, shaiton
<shaiton(a)fedoraproject.org> wrote:
>>>>>
>>>>> > On Mon, Oct 18, 2010 at 4:07 PM, אלעד <el.il(a)doom.co.il>
wrote:
>>>>> > > wait, now when i think about it, there is something very
important to
>>>>> > > do before publishing the new POT, make sure that the
" Some header
>>>>> > > strings (eg. "Tutorials, tips & tricks to make
your Fedora experience
>>>>> > > awesome!") including those facts in the side of the
header (in the
>>>>> > > tutorials, in the interviews and in the main Using Fedora
page) aren't
>>>>> > > in the POT file, so they can't be translated. "
is fixed
>>>>> > > if it is not fixed, you will need to update the POT
again.
>>>>> > >
>>>>> >
>>>>> > We should also check if there is no "${Markup('"
strings instead of
>>>>> > "${Markup(_('" as I've explained in an other
thread. I'm still at
>>>>> > work, I am not sure to have the time tonight.
>>>>>
>>>>> I will poke through the files and find any of those references and
fix them
>>>>> tonight.
>>>>
>>>> Thanks folks, these changes really helped. I also found some
>>>> additional strings that hadn't been marked and corrected them too.
>>>
>>>
>>>> Another additional fix I made... I turned this:
>>>> ${_('Read more >')}
>>>> Into this:
>>>> ${_('Read more')} >
>>>
>>> Great thanks.
>>> I was wondering if the " >" would be "translatable"
regarding RTL langages.
>>> They don't need to change it?
>>>
>> Yes, we do need to change it, otherwise it will point to the wrong direction.
>
> My mistake, I'll revert that immediately!
>
> Hopefully this shows the importance of doing "single-purpose" commits
> -- easy to revert!
>
> Paul
>
> (P.S. Side note -- if a conversation is bottom-posted, I try to bottom
> post replies. If it's top posted I top post my reply. Jumping back and
> forth is confusing.)
>
the POT and PO files still has the old strings from before you
reverted the commit. please update those accordingly.
Done as requested, thanks!
--
Paul W. Frields
http://paul.frields.org/
gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233 5906 ACDB C937 BD11 3717
http://redhat.com/ - - - -
http://pfrields.fedorapeople.org/
Where open source multiplies:
http://opensource.com